-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of Functional Programming section #148
Open
nicolaspayette
wants to merge
8
commits into
main
Choose a base branch
from
fp_review
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 1, 2024
-
fix bug in C++ calc_min_max example (#134)
By starting the reduction with a (0, 0) tuple, the function returned an incorrect minimum of zero if all inputs were positive or an incorrect maximum of zero if all inputs were negative. The new version assumes that the `data` vector is not empty, which is always the case here but might not be in real life. I think that's fine for an example. I also swapped `std::reduce` for `std::accumulate` to be more consistent with the rest of the text. It's sequential by default, and we're still providing an initial element, so I think it's strictly equivalent in this case, but I haven't tested it.
Configuration menu - View commit details
-
Copy full SHA for 8705604 - Browse repository at this point
Copy the full SHA 8705604View commit details -
swap
std::reduce
forstd::accumulate
in sum of squares ex. (#134)Again, for consistency with the rest of the text. I also believe it's strictly equivalent here, but it might be worth double-checking.
Configuration menu - View commit details
-
Copy full SHA for 89e9ddd - Browse repository at this point
Copy the full SHA 89e9dddView commit details -
tweak higher_order_function_cpp text (#134)
including adding hyphens to "higher-order functions"
Configuration menu - View commit details
-
Copy full SHA for 965d564 - Browse repository at this point
Copy the full SHA 965d564View commit details -
remove 2nd intentional bug in Python's Game of Life impl. (#134)
Feel free to overrule me on this, but it felt very ad hoc to me and was not present in the C++ version.
Configuration menu - View commit details
-
Copy full SHA for 05b11e6 - Browse repository at this point
Copy the full SHA 05b11e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a83efab - Browse repository at this point
Copy the full SHA a83efabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 826e0cd - Browse repository at this point
Copy the full SHA 826e0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d107fb - Browse repository at this point
Copy the full SHA 6d107fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13591db - Browse repository at this point
Copy the full SHA 13591dbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.