Pr 18 review fixes #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscharett
reviewed
Sep 26, 2017
| @@ -38,7 +38,7 @@ | |||
| <cbp-applications-search></cbp-applications-search> | |||
|
|
|||
|
|
|||
| <div class="mat-menu-item cbp-applications-refresh" (click)="reloadApplicationsData($event)"> | |||
| <div class="mat-menu-item cbp-applications-refresh" role="button" (click)="reloadApplicationsData($event)"> | |||
There was a problem hiding this comment.
Not sure this solves the issue. Is the div focusable? also, does it have the right keyboard actions? https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_button_role
There was a problem hiding this comment.
It does not have keyboard actions. It should. Unfortunately can't use mdButton to get the benefits of accessibility out of the box.
There was a problem hiding this comment.
Assigned #21 to @jscharett
|
Declining/Closing this PR. It will be addressed in #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes as per the review comments on #18