Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr 18 review fixes #19

Closed
wants to merge 2 commits into from
Closed

Pr 18 review fixes #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3e5fb
adding role = button to make this accessible since default button is …
yogeshgadge Sep 25, 2017
469b60b
typo stopPropagation
yogeshgadge Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/applications/applications-menu/applications-menu.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<cbp-applications-search></cbp-applications-search>


<div class="mat-menu-item cbp-applications-refresh" (click)="reloadApplicationsData($event)">
<div class="mat-menu-item cbp-applications-refresh" role="button" (click)="reloadApplicationsData($event)">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this solves the issue. Is the div focusable? also, does it have the right keyboard actions? https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_button_role

Copy link
Collaborator Author

@yogeshgadge yogeshgadge Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not have keyboard actions. It should. Unfortunately can't use mdButton to get the benefits of accessibility out of the box.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigned #21 to @jscharett

<div>Refresh</div>
</div>
<div class="cbp-applications-last-updated" (click)="stopPropogation($event)">
Expand Down
2 changes: 1 addition & 1 deletion src/app/applications/applications-search/applications-search.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<form>
<md-form-field (click)="stopPropogation($event)" floatPlaceholder="never">
<md-form-field (click)="stopPropagation($event)" floatPlaceholder="never">
<input color="white" type="text" mdInput aria-label="Number" [formControl]="searchTokenControl" name="searchToken" placeholder="&nbsp;&nbsp;Search ..."
class="cbp-applications-search-input">
</md-form-field>
Expand Down
2 changes: 1 addition & 1 deletion src/app/applications/applications-search/applications-search.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import {Observable} from 'rxjs/Observable';
}
return this.searchResults;
}
stopPropogation($event: Event) {
stopPropagation($event: Event) {
$event.stopPropagation();
}

Expand Down