Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix dev server unable to compile #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PixnBits
Copy link
Contributor

node built-in modules not needed for d3-request dependency

admittedly I'm unable to run the tests yet as I'm unsure how to configure a chrome launcher on my pixelbook, hoping Travis is still building these

node built-in modules not needed for d3-request dependency
@PixnBits
Copy link
Contributor Author

On the upside Travis is building PRs and webpack was able to build, but it looks like the saucelabs connectivity is broken

  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null

going to try out adding a change from karma-runner/karma-sauce-launcher#73 to this PR, which is a bit of scope creep but given this is the first PR in a while maybe the scope is less webpack and more PR builds \m/

@PixnBits
Copy link
Contributor Author

Misconfigured -- Sauce Labs Authentication Error.
You used username 'None' and access key 'None' to authenticate, which are not valid Sauce Labs credentials.

Connecting, so that's progress. Going to also add username+password from env vars. Not sure if they're configured, so 🤞
I'd like to squash some of these commits before a merge 😛

@PixnBits
Copy link
Contributor Author

Rats, looks like that was fruitless anyway as process.env.SAUCE_USERNAME is the default anyway.

@austinpray
Copy link
Member

Hey friend! Thanks for the PRs! I apologize for not following up: you caught me on vacation. I’m back tomorrow though and can review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants