-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/contain nltk assets in docker image #3853
Feat/contain nltk assets in docker image #3853
Conversation
# Conflicts: # CHANGELOG.md # unstructured/__version__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would love to see a bit of stability with how Unstructured handles NLTK install. In the past ~2 months this has broken twice without any warning for us. |
I agree @NolanTrem, it was surprising for us that a bugfix version bump would break our tests. Downloading the NLTK stuff at container build time is fine, removing automatic downloading if found missing is not backwards compatible for a lot of folks. |
This pull request adds NLTK data to the Docker image by pre-packaging the data to ensure a more reliable and efficient deployment process, as the required NLTK resources are readily available within the container.
Current updated solution: