rename delegate function

WizelineLabs · Aug 1, 2019 · c6714fa · c6714fa
1 parent aa2e537
commit c6714fa
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/Example/Tests/DelegateTests.swift b/Example/Tests/DelegateTests.swift
@@ -19,30 +19,30 @@ class DelegateTests: XCTestCase {
     func testShouldScrollDelegatePropertyOnTableDefault() {
         let defaultTableViewController = DefaultTableViewController()
 
-        let shouldScrollTableView = defaultTableViewController.tableView.emptyStateDelegate?.emptyStateShouldScroll()
-        XCTAssertEqual(true, shouldScrollTableView)
+        let enableScrollForEmptyState = defaultTableViewController.tableView.emptyStateDelegate?.enableScrollForEmptyState()
+        XCTAssertEqual(true, enableScrollForEmptyState)
     }
 
     func testShouldScrollDelegatePropertyOnTableCustom() {
         let customTableViewController = CustomEmptyStateTableViewController()
 
-        let shouldScrollTableView = customTableViewController.tableView.emptyStateDelegate?.emptyStateShouldScroll()
-        XCTAssertEqual(false, shouldScrollTableView)
+        let enableScrollForEmptyState = customTableViewController.tableView.emptyStateDelegate?.enableScrollForEmptyState()
+        XCTAssertEqual(false, enableScrollForEmptyState)
     }
 
     // MARK: - UICollectionView
     func testShouldScrollDelegatePropertyOnCollectionDefault() {
         let defaultCollectionViewController = DefaultCollectionViewController(collectionViewLayout: UICollectionViewFlowLayout())
 
-        let shouldScrollTableView = defaultCollectionViewController.collectionView.emptyStateDelegate?.emptyStateShouldScroll()
-        XCTAssertEqual(true, shouldScrollTableView)
+        let enableScrollForEmptyState = defaultCollectionViewController.collectionView.emptyStateDelegate?.enableScrollForEmptyState()
+        XCTAssertEqual(true, enableScrollForEmptyState)
     }
 
     func testShouldScrollDelegatePropertyOnCollectionCustom() {
         let customCollectionViewController = CustomCollectionViewController(collectionViewLayout: UICollectionViewFlowLayout())
 
-        let shouldScrollTableView = customCollectionViewController.collectionView.emptyStateDelegate?.emptyStateShouldScroll()
-        XCTAssertEqual(false, shouldScrollTableView)
+        let enableScrollForEmptyState = customCollectionViewController.collectionView.emptyStateDelegate?.enableScrollForEmptyState()
+        XCTAssertEqual(false, enableScrollForEmptyState)
     }
 
 }
diff --git a/WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift b/WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift
@@ -61,7 +61,7 @@ extension UICollectionView: WLEmptyStateProtocol {
 
         if numberOfItems == 0 && self.subviews.count > 1 {
             originalScrollingValue = isScrollEnabled
-            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? DefaultConstants.shouldScrollOnEmptyState
+            isScrollEnabled = emptyStateDelegate?.enableScrollForEmptyState() ?? DefaultConstants.enableScrollForEmptyState
 
             backgroundView = emptyStateView
             if let emptyStateView = emptyStateView as? EmptyStateView {

diff --git a/WLEmptyState/Classes/Extensions/UITableView+WLEmptyState.swift b/WLEmptyState/Classes/Extensions/UITableView+WLEmptyState.swift
@@ -62,7 +62,7 @@ extension UITableView: WLEmptyStateProtocol {
 
         if numberOfItems == 0 && self.subviews.count > 1 {
             originalScrollingValue = isScrollEnabled
-            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? DefaultConstants.shouldScrollOnEmptyState
+            isScrollEnabled = emptyStateDelegate?.enableScrollForEmptyState() ?? DefaultConstants.enableScrollForEmptyState
 
             addSubview(emptyStateView)
             if let emptyStateView = emptyStateView as? EmptyStateView {

diff --git a/WLEmptyState/Classes/Misc/DefaultConstants.swift b/WLEmptyState/Classes/Misc/DefaultConstants.swift
@@ -9,6 +9,6 @@ import Foundation
 
 enum DefaultConstants {
 
-    static let shouldScrollOnEmptyState: Bool = true
+    static let enableScrollForEmptyState: Bool = true
 
 }
diff --git a/WLEmptyState/Classes/Protocols/WLEmptyStateDelegate.swift b/WLEmptyState/Classes/Protocols/WLEmptyStateDelegate.swift
@@ -9,13 +9,13 @@
 import Foundation
 
 public protocol WLEmptyStateDelegate: class {
-    func emptyStateShouldScroll() -> Bool
+    func enableScrollForEmptyState() -> Bool
 }
 
 public extension WLEmptyStateDelegate {
 
-    func emptyStateShouldScroll() -> Bool {
-        return DefaultConstants.shouldScrollOnEmptyState
+    func enableScrollForEmptyState() -> Bool {
+        return DefaultConstants.enableScrollForEmptyState
     }
 
 }