-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-2675 Only validate required props in null-safe components #917
FED-2675 Only validate required props in null-safe components #917
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes and test coverage look great to me, +1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-pp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
over_react should only perform required prop validation for components that have migrated to null safety.
That way, during null safety migrations, packages that export prop mixins will be able to make props required without also causing them to be required in components that mix in those props in other packages (assuming those downstream components haven't migrated to null safety out of order), preventing a breaking change.
Then, when the components using the prop mixins are migrated to null safety, the required prop validation errors would take effect, at which point the consumers could add the appropriate
@Props(disableRequiredPropValidation: {...})
annotations.This will make it easier and safer to make props required in mixins that are used in wrapper components, like certain RMUI props mixins (like AutocompletePropsMixin).
See [this thread] for more info and an initial spike implementation: https://workiva.slack.com/archives/C063ZQ70Y7P/p1714608338493519
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: