FED-2675 Only validate required props in null-safe components

lib/src/builder/codegen/typed_map_impl_generator.dart

@@ -265,6 +265,17 @@ abstract class TypedMapImplGenerator extends BoilerplateDeclarationGenerator {
         ..writeln('  @override')
         ..writeln(
             '  String \$getPropKey(void Function(Map m) accessMap) => $topLevelGetPropKeyAliasName(accessMap, (map) => ${names.implName}(map));');
+
+      if (!nullSafety) {
+        buffer
+          ..writeln()
+          ..writeln('  @override')
+          ..writeln('  // ignore: must_call_super')
+          ..writeln('  validateRequiredProps() {')
+          ..writeln(
+              '    // Disable required prop validation, until this component is null safe, by not calling super.')
+          ..writeln('  }');
+      }
     }
     final requiredPropNamesToSkipValidation = this.requiredPropNamesToSkipValidation;
     if (requiredPropNamesToSkipValidation != null && requiredPropNamesToSkipValidation.isNotEmpty) {

test/over_react/component_declaration/builder_integration_tests/new_boilerplate/null_safety_validate_required_props_test.dart

@@ -27,7 +27,7 @@ void main() {
         group('on invocation', () {
           test('via call()', () {
             expect(() {
-              (ComponentTest()
+              (RequiredPropsTest()
                 ..requiredNullable = true
               )();
             },
@@ -40,7 +40,7 @@ void main() {
 
           test('via build()', () {
             expect(() {
-              (ComponentTest()
+              (RequiredPropsTest()
                 ..requiredNullable = true
               ).build();
             },
@@ -54,7 +54,7 @@ void main() {
 
         test('on mount', () {
           expect(() {
-            rtl.render((ComponentTest()
+            rtl.render((RequiredPropsTest()
               ..requiredNullable = true
             )());
           },
@@ -69,14 +69,14 @@ void main() {
           late rtl.RenderResult view;
 
           expect(() {
-            view = rtl.render((ComponentTest()
+            view = rtl.render((RequiredPropsTest()
               ..requiredNonNullable = true
               ..requiredNullable = true
             )());
           }, returnsNormally);
 
           expect(() {
-            view.rerender((ComponentTest()
+            view.rerender((RequiredPropsTest()
               ..requiredNullable = true
             )());
           },
@@ -90,7 +90,7 @@ void main() {
 
       test('does not throw when the prop is set', () {
         expect(() {
-          rtl.render((ComponentTest()
+          rtl.render((RequiredPropsTest()
             ..requiredNonNullable = true
             ..requiredNullable = true
           )());
@@ -103,7 +103,7 @@ void main() {
         group('on invocation', () {
           test('via call()', () {
             expect(() {
-              (ComponentTest()
+              (RequiredPropsTest()
                 ..requiredNonNullable = true
               )();
             },
@@ -115,7 +115,7 @@ void main() {
 
           test('via build()', () {
             expect(() {
-              (ComponentTest()
+              (RequiredPropsTest()
                 ..requiredNonNullable = true
               ).build();
             },
@@ -128,7 +128,7 @@ void main() {
 
         test('on mount', () {
           expect(() {
-            rtl.render((ComponentTest()
+            rtl.render((RequiredPropsTest()
               ..requiredNonNullable = true
             )());
           },
@@ -142,14 +142,14 @@ void main() {
           late rtl.RenderResult view;
 
           expect(() {
-            view = rtl.render((ComponentTest()
+            view = rtl.render((RequiredPropsTest()
               ..requiredNonNullable = true
               ..requiredNullable = true
             )());
           }, returnsNormally);
 
           expect(() {
-            view.rerender((ComponentTest()
+            view.rerender((RequiredPropsTest()
               ..requiredNonNullable = true
             )());
           },
@@ -162,7 +162,7 @@ void main() {
 
       test('does not throw when the prop is set to null', () {
         expect(() {
-          rtl.render((ComponentTest()
+          rtl.render((RequiredPropsTest()
             ..requiredNonNullable = true
             ..requiredNullable = null
           )());
@@ -171,7 +171,7 @@ void main() {
 
       test('does not throw when the prop is set', () {
         expect(() {
-          rtl.render((ComponentTest()
+          rtl.render((RequiredPropsTest()
             ..requiredNonNullable = true
             ..requiredNullable = true
           )());
@@ -181,7 +181,7 @@ void main() {
 
     test('@disableRequiredPropValidation annotation turns off validation for specific props', () {
       expect(() {
-        rtl.render((ComponentTest()
+        rtl.render((RequiredPropsTest()
           ..requiredNonNullable = true
           ..requiredNullable = true
         )());
@@ -190,7 +190,7 @@ void main() {
 
     test('disableRequiredPropValidation method turns off validation for component usage', () {
       expect(() {
-        rtl.render((ComponentTest()
+        rtl.render((RequiredPropsTest()
           ..disableRequiredPropValidation()
         )());
       }, allOf(returnsNormally, logsNoPropTypeWarnings));
@@ -301,18 +301,18 @@ void main() {
 
   test('(New boilerplate) validates required props: does not throw in dart2js', () {
     expect(() {
-      rtl.render(ComponentTest()());
-      rtl.render(ComponentTest().build());
+      rtl.render(RequiredPropsTest()());
+      rtl.render(RequiredPropsTest().build());
     },
     returnsNormally);
   }, tags: 'no-ddc');
 }
 
 // ignore: undefined_identifier, invalid_assignment
-UiFactory<ComponentTestProps> ComponentTest = _$ComponentTest;
+UiFactory<RequiredPropsTestProps> RequiredPropsTest = _$RequiredPropsTest;
 
 @Props(disableRequiredPropValidation: {'testIgnoreOnMixin'})
-mixin ComponentTestProps on UiProps {
+mixin RequiredPropsTestProps on UiProps {
   late bool requiredNonNullable;
 
   late bool? requiredNullable;
@@ -332,7 +332,7 @@ mixin ComponentTestProps on UiProps {
   late bool testIgnoreOnMixin;
 }
 
-class ComponentTestComponent extends UiComponent2<ComponentTestProps> {
+class RequiredPropsTestComponent extends UiComponent2<RequiredPropsTestProps> {
   @override
   render() => Dom.div()();
 }
@@ -347,7 +347,7 @@ mixin MultipleMixinsTestPropsMixin on UiProps {
 }
 
 @Props(disableRequiredPropValidation: {'testIgnoreOnMixin'})
-class MultipleMixinsTestProps = UiProps with MultipleMixinsTestPropsMixin, ComponentTestProps;
+class MultipleMixinsTestProps = UiProps with MultipleMixinsTestPropsMixin, RequiredPropsTestProps;
 
 
 mixin WrapperTestPropsMixin on UiProps {
@@ -361,7 +361,7 @@ UiFactory<FunctionWrapperTestProps> FunctionWrapperTest = uiFunction(
 
 
 @Props(disableRequiredPropValidation: {'thirdRequiredProp', 'secondRequiredProp', 'requiredNonNullable', 'requiredNullable', 'testIgnoreOnMixin'})
-class FunctionWrapperTestProps = UiProps with WrapperTestPropsMixin, MultipleMixinsTestPropsMixin, ComponentTestProps;
+class FunctionWrapperTestProps = UiProps with WrapperTestPropsMixin, MultipleMixinsTestPropsMixin, RequiredPropsTestProps;
 
 @Factory()
 // ignore: undefined_identifier, invalid_assignment
@@ -396,7 +396,7 @@ mixin ClassWrapperTest2PropsMixin on UiProps {
 }
 
 @Props(disableRequiredPropValidation: {'thirdRequiredProp', 'secondRequiredProp', 'requiredNonNullable', 'requiredNullable', 'testIgnoreOnMixin'})
-class ClassWrapperTest2Props = UiProps with ClassWrapperTest2PropsMixin, MultipleMixinsTestPropsMixin, ComponentTestProps;
+class ClassWrapperTest2Props = UiProps with ClassWrapperTest2PropsMixin, MultipleMixinsTestPropsMixin, RequiredPropsTestProps;
 
 class ClassWrapperTest2Component extends UiComponent2<ClassWrapperTest2Props> {
   @override

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/annotation_error_integration_test.over_react.g.dart

@@ -81,6 +81,12 @@ class _$$AnnotationErrorDefaultPropsProps
       _$getPropKey$_$$AnnotationErrorDefaultPropsProps(
           accessMap, (map) => _$$AnnotationErrorDefaultPropsProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation => const {'id'};
 }
@@ -183,6 +189,12 @@ class _$$AnnotationErrorProps extends _$AnnotationErrorProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$AnnotationErrorProps(
           accessMap, (map) => _$$AnnotationErrorProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl
@@ -282,6 +294,12 @@ class _$$AnnotationErrorStatefulProps extends _$AnnotationErrorStatefulProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$AnnotationErrorStatefulProps(
           accessMap, (map) => _$$AnnotationErrorStatefulProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl
@@ -436,6 +454,12 @@ class _$$AnnotationErrorStatefulDefaultPropsProps
       _$getPropKey$_$$AnnotationErrorStatefulDefaultPropsProps(
           accessMap, (map) => _$$AnnotationErrorStatefulDefaultPropsProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation => const {'id'};
 }

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/component_integration_test.over_react.g.dart

@@ -219,6 +219,12 @@ abstract class _$$ComponentTestProps extends _$ComponentTestProps
       _$getPropKey$_$$ComponentTestProps(
           accessMap, (map) => _$$ComponentTestProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation =>
       const {'id', 'shouldSetPropsDirectly', 'shouldUseJsFactory'};
@@ -379,6 +385,12 @@ abstract class _$$IsErrorBoundaryProps extends _$IsErrorBoundaryProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$IsErrorBoundaryProps(
           accessMap, (map) => _$$IsErrorBoundaryProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl
@@ -535,6 +547,12 @@ abstract class _$$IsNotErrorBoundaryProps extends _$IsNotErrorBoundaryProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$IsNotErrorBoundaryProps(
           accessMap, (map) => _$$IsNotErrorBoundaryProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/constant_required_accessor_integration_test.over_react.g.dart

@@ -137,6 +137,12 @@ abstract class _$$ComponentTestProps extends _$ComponentTestProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$ComponentTestProps(
           accessMap, (map) => _$$ComponentTestProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/do_not_generate_accessor_integration_test.over_react.g.dart

@@ -140,6 +140,12 @@ abstract class _$$DoNotGenerateAccessorTestProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$DoNotGenerateAccessorTestProps(
           accessMap, (map) => _$$DoNotGenerateAccessorTestProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/namespaced_accessor_integration_test.over_react.g.dart

@@ -197,6 +197,12 @@ abstract class _$$NamespacedAccessorTestProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$NamespacedAccessorTestProps(
           accessMap, (map) => _$$NamespacedAccessorTestProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/private_props_ddc_bug.over_react.g.dart

@@ -87,6 +87,12 @@ abstract class _$$FooProps extends _$FooProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$FooProps(accessMap, (map) => _$$FooProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation => const {'_privateProp'};
 }

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/required_accessor_integration_test.over_react.g.dart

@@ -158,6 +158,12 @@ abstract class _$$ComponentTestProps extends _$ComponentTestProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$ComponentTestProps(
           accessMap, (map) => _$$ComponentTestProps(map));
+
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
 }
 
 /// An alias for [getPropKey] so it can be referenced within the props class impl

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/stateful_component_integration_test.over_react.g.dart

@@ -103,6 +103,12 @@ abstract class _$$StatefulComponentTestProps
       _$getPropKey$_$$StatefulComponentTestProps(
           accessMap, (map) => _$$StatefulComponentTestProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation =>
       const {'setStateDirectly'};

test/over_react/component_declaration/non_null_safe_builder_integration_tests/component2/unassigned_prop_integration_test.over_react.g.dart

@@ -106,6 +106,12 @@ abstract class _$$FooProps extends _$FooProps
   String $getPropKey(void Function(Map m) accessMap) =>
       _$getPropKey$_$$FooProps(accessMap, (map) => _$$FooProps(map));
 
+  @override
+  // ignore: must_call_super
+  validateRequiredProps() {
+    // Disable required prop validation, until this component is null safe, by not calling super.
+  }
+
   @override
   Set<String> get requiredPropNamesToSkipValidation => const {'id'};
 }