Integrity protection #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@developer-variety Thanks, will glad to see your fork :D |
XenocodeRCE
reviewed
Aug 27, 2018
| file.BaseStream.Position = file.BaseStream.Length - 32; | ||
| string b = Encoding.ASCII.GetString(file.ReadBytes(32)); | ||
|
|
||
| if (a != b) |
There was a problem hiding this comment.
I still haven't pushed this PR because there is a huge security flaw here : what prevents me from decompiling the protected file and NOP this if statement ? @rexyrexy
lcsondes
reviewed
Jan 11, 2019
|
|
||
| internal static string Hash(byte[] metin) | ||
| { | ||
| MD5CryptoServiceProvider md5 = new MD5CryptoServiceProvider(); |
There was a problem hiding this comment.
MD5 is extremely obsolete, even something as old as SHA-1 is faster and more secure.
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.