Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity protection #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions Confuser.Runtime/IntegrityProtection.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
using System;
using System.IO;
using System.Security.Cryptography;
using System.Text;

namespace Confuser.Runtime
{
internal static class IntegrityProtection
{
internal static void Initialize()
{
var bas = new StreamReader(typeof(IntegrityProtection).Assembly.Location).BaseStream;
var file = new BinaryReader(bas);
var file2 = File.ReadAllBytes(typeof(IntegrityProtection).Assembly.Location);

var byt = file.ReadBytes(file2.Length - 32);
var a = Hash(byt);
file.BaseStream.Position = file.BaseStream.Length - 32;
string b = Encoding.ASCII.GetString(file.ReadBytes(32));

if (a != b)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still haven't pushed this PR because there is a huge security flaw here : what prevents me from decompiling the protected file and NOP this if statement ? @rexyrexy

throw new BadImageFormatException();
}

internal static string Hash(byte[] metin)
{
MD5CryptoServiceProvider md5 = new MD5CryptoServiceProvider();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MD5 is extremely obsolete, even something as old as SHA-1 is faster and more secure.

byte[] btr = metin;
btr = md5.ComputeHash(btr);
StringBuilder sb = new StringBuilder();

foreach (byte ba in btr)
{
sb.Append(ba.ToString("x2").ToLower());
}
return sb.ToString();
}
}
}