-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(actions): allow more flexibility on cached states usage #8908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
C-design
Category: Software design work
A-infrastructure
Area: Infrastructure changes
A-devops
Area: Pipelines, CI/CD and Dockerfiles
I-usability
Zebra is hard to understand or use
P-High 🔥
labels
Oct 3, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Oct 3, 2024
7 tasks
upbqdn
reviewed
Oct 7, 2024
@gustavovalverde can you update this branch? I can't do it. |
Co-authored-by: Marek <[email protected]>
gustavovalverde
force-pushed
the
imp-cd-disk-mgm
branch
from
October 11, 2024 18:57
7d17068
to
301fa96
Compare
@upbqdn this one should be ready to merge |
upbqdn
reviewed
Oct 14, 2024
3 tasks
This supersedes #8936 using a different approach with `${VAR:-value}`
upbqdn
approved these changes
Oct 17, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
A-infrastructure
Area: Infrastructure changes
C-design
Category: Software design work
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
P-High 🔥
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've added the possibility to deploy instances with a cached state attached, but we might also want to deploy them without it, or change the cached state disk preference depending on the github source, while not affecting our actual deployment process.
Solution
tip
orcheckpoint
)main
branch vsPR
orany
other available)main
branch, without disallowing finding other available disksTests
Follow-up Work
Support the
matrix
use case when releasing a new Zebra version:zebra/.github/workflows/cd-deploy-nodes-gcp.yml
Line 233 in 2552c3c
PR Author's Checklist
PR Reviewer's Checklist