Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(actions): allow more flexibility on cached states usage #8908

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Oct 3, 2024

Motivation

We've added the possibility to deploy instances with a cached state attached, but we might also want to deploy them without it, or change the cached state disk preference depending on the github source, while not affecting our actual deployment process.

Solution

  • Allow to select a cached state based on:
    • Type of cached disk to use (tip or checkpoint)
    • Source (main branch vs PR or any other available)
    • Network
  • Allow to deploy a node without cached state
  • Search for branch/PR reference instead of commit (as this is an use case that we haven't used for a while)
  • Improve the disk selection logic, by allowing a preference for cached states from the main branch, without disallowing finding other available disks

Tests

Follow-up Work

Support the matrix use case when releasing a new Zebra version:

name: Deploy ${{ matrix.network }} nodes

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added C-design Category: Software design work A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles I-usability Zebra is hard to understand or use P-High 🔥 labels Oct 3, 2024
@gustavovalverde gustavovalverde self-assigned this Oct 3, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 3, 2024
@gustavovalverde gustavovalverde marked this pull request as ready for review October 3, 2024 14:32
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 3, 2024 14:32
@gustavovalverde gustavovalverde requested review from upbqdn and removed request for a team October 3, 2024 14:32
.github/workflows/cd-deploy-nodes-gcp.yml Outdated Show resolved Hide resolved
.github/workflows/cd-deploy-nodes-gcp.yml Outdated Show resolved Hide resolved
.github/workflows/cd-deploy-nodes-gcp.yml Outdated Show resolved Hide resolved
.github/workflows/scripts/gcp-get-cached-disks.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/gcp-get-cached-disks.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/gcp-get-cached-disks.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/gcp-get-cached-disks.sh Outdated Show resolved Hide resolved
@oxarbitrage oxarbitrage added the do-not-merge Tells Mergify not to merge this PR label Oct 10, 2024
@upbqdn
Copy link
Member

upbqdn commented Oct 11, 2024

@gustavovalverde can you update this branch? I can't do it.

@gustavovalverde
Copy link
Member Author

@upbqdn this one should be ready to merge

@gustavovalverde gustavovalverde removed the do-not-merge Tells Mergify not to merge this PR label Oct 14, 2024
mergify bot added a commit that referenced this pull request Oct 17, 2024
@mergify mergify bot merged commit cc78b6a into main Oct 17, 2024
169 checks passed
@mergify mergify bot deleted the imp-cd-disk-mgm branch October 17, 2024 13:08
@upbqdn upbqdn mentioned this pull request Oct 25, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-design Category: Software design work C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants