-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MIAB dns create TXT record format #5268
Conversation
The MIAB API requires that the txtvlaue to a TXT record includes the "value=" and "ttl=" components as part of the TXT record when adding a new record.
Corrected typo
Welcome |
Ok, the change has been tested and is working. Anything else that I need
to do to get the change merged?
…On Mon, 26 Aug 2024 at 11:14, github-actions[bot] ***@***.***> wrote:
*Welcome*
First thing: don't send PR to the master branch, please send to the dev
branch instead.
Please make sure you've read our DNS API Dev Guide
<http://../wiki/DNS-API-Dev-Guide> and DNS-API-Test
<http://../wiki/DNS-API-Test>.
Then reply on this message, otherwise, your code will not be reviewed or
merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test <http://../wiki/DNS-API-Test> 才会被 review. 无论是修改,
还是新加的 dns api, 都必须确保通过这个测试.
—
Reply to this email directly, view it on GitHub
<#5268 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEZPJYKUB354MRGJWG2DX3ZTLWXNAVCNFSM6AAAAABNDTKDL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZG4ZTONZVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'm struggling with the test. Do I need to run tests for all the possible environments, or do I test it on Linux 64bit (for example) and then redo a PR? The dns.yml file contains all the possible environments... |
The change now has passed all the tests which would run... I presume the skipped tests are intentional? |
@Neilpang, do I just wait now? |
No description provided.