Fix MIAB dns create TXT record format #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MIAB API requires that the txtvlaue to a TXT record includes the "value=" and "ttl=" components as part of the TXT record when adding a new record.
Corrected typo
|
Welcome |
|
Ok, the change has been tested and is working. Anything else that I need
to do to get the change merged?
…On Mon, 26 Aug 2024 at 11:14, github-actions[bot] ***@***.***> wrote:
*Welcome*
First thing: don't send PR to the master branch, please send to the dev
branch instead.
Please make sure you've read our DNS API Dev Guide
<http://../wiki/DNS-API-Dev-Guide> and DNS-API-Test
<http://../wiki/DNS-API-Test>.
Then reply on this message, otherwise, your code will not be reviewed or
merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test <http://../wiki/DNS-API-Test> 才会被 review. 无论是修改,
还是新加的 dns api, 都必须确保通过这个测试.
—
Reply to this email directly, view it on GitHub
<#5268 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEZPJYKUB354MRGJWG2DX3ZTLWXNAVCNFSM6AAAAABNDTKDL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZG4ZTONZVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm struggling with the test. Do I need to run tests for all the possible environments, or do I test it on Linux 64bit (for example) and then redo a PR? The dns.yml file contains all the possible environments... |
|
The change now has passed all the tests which would run... I presume the skipped tests are intentional? |
|
@Neilpang, do I just wait now? |
This was referenced Oct 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.