Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MIAB dns create TXT record format #5268

Merged
merged 12 commits into from
Sep 9, 2024
Merged

Fix MIAB dns create TXT record format #5268

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d59d43
Merge pull request #5255 from acmesh-official/dev
Neilpang Aug 20, 2024
435bb3f
Update dns_miab.sh
lifeboy Aug 21, 2024
0122eab
Update dns_miab.sh
lifeboy Aug 21, 2024
42e78f9
changes not yet tested
lifeboy Aug 21, 2024
fa3591f
TXT record ADD test successfully
lifeboy Aug 22, 2024
fab292d
correct a typo
lifeboy Aug 27, 2024
65c3dc2
Added comments
lifeboy Sep 2, 2024
9cec268
Syntax corrections suggested by testing script
lifeboy Sep 2, 2024
3006c90
Syntax corrections suggested by testing script
lifeboy Sep 2, 2024
031d53b
Syntax corrections suggested by testing script
lifeboy Sep 2, 2024
dc6ea97
Syntax corrections, previous change broke script
lifeboy Sep 2, 2024
02fb40c
Syntax corrections, previous change broke script
lifeboy Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dnsapi/dns_miab.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ Author: Darven Dissek, William Gertz
#Usage: dns_miab_add _acme-challenge.www.domain.com "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
dns_miab_add() {
fulldomain=$1
txtvalue=$2
_info "Using miab challange add"
# Added "value=" and "&ttl=300" to accomodate the new TXT record format used by the MIAB/PMIAB API
txtvalue="value=$2&ttl=300"
_info "Using miab challenge add"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"

Expand All @@ -26,7 +27,7 @@ dns_miab_add() {
return 1
fi

#check domain and seperate into doamin and host
#check domain and seperate into domain and host
if ! _get_root "$fulldomain"; then
_err "Cannot find any part of ${fulldomain} is hosted on ${MIAB_Server}"
return 1
Expand Down Expand Up @@ -55,7 +56,7 @@ dns_miab_rm() {
fulldomain=$1
txtvalue=$2

_info "Using miab challage delete"
_info "Using miab challenge delete"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"

Expand Down
Loading