fix(ci): fix docker image save/load #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the `>` character might have issues with yaml.
hsheth2
commented
Jan 27, 2025
| @@ -265,8 +266,6 @@ jobs: | |||
| DATAHUB_TELEMETRY_ENABLED: false | |||
| DATAHUB_ACTIONS_IMAGE: acryldata/datahub-actions-slim | |||
| DATAHUB_ACTIONS_VERSION: ${{ needs.setup.outputs.unique_tag }} | |||
| ACTIONS_EXTRA_PACKAGES: "acryl-datahub-actions[executor]==0.0.13 acryl-datahub-actions==0.0.13 acryl-datahub==0.10.5" | |||
| ACTIONS_CONFIG: "https://raw.githubusercontent.com/acryldata/datahub-actions/main/docker/config/executor.yaml" | |||
There was a problem hiding this comment.
we don't use the entrypoint from the base image, so these two env vars didn't do anything. removing them to make it more clear
anshbansal
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
>character might cause issues with / get misinterpreted by yaml. Prior to this, smoke tests would always fail in CI, although I'm not sure when things stopped working.Also makes some tweaks to ensure that smoke tests run on all code changes, and that they use the latest code. If we had this, we would've caught the regression from #142.