Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix docker image save/load #159

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix(ci): fix docker image save/load #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5d64f
fix(ci): fix docker image save/load
hsheth2 Jan 27, 2025
46f250a
ensure it runs on all code with latest
hsheth2 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/datahub-actions-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
- main
paths:
- "docker/**"
- "datahub-actions/**"
- ".github/workflows/datahub-actions-docker.yml"
- "!build/**"
- "!**.md"
Expand Down Expand Up @@ -148,7 +149,7 @@ jobs:
"APP_ENV=prod-slim"
- name: Save Docker image
if: needs.setup.outputs.publish != 'true'
run: docker save ${{ steps.docker_meta_slim.outputs.tags }} > image.tar
run: docker image save -o image.tar ${{ steps.docker_meta_slim.outputs.tags }}
- name: Upload artifact
if: needs.setup.outputs.publish != 'true'
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -205,7 +206,7 @@ jobs:
name: docker-image
- name: Load Docker image (if not publishing)
if: needs.setup.outputs.publish != 'true'
run: docker load < image.tar
run: docker image load -i image.tar
- name: Pull Docker image (if publishing)
if: needs.setup.outputs.publish == 'true'
run: docker pull acryldata/datahub-actions-slim:${{ needs.setup.outputs.unique_tag }}
Expand Down Expand Up @@ -265,8 +266,6 @@ jobs:
DATAHUB_TELEMETRY_ENABLED: false
DATAHUB_ACTIONS_IMAGE: acryldata/datahub-actions-slim
DATAHUB_ACTIONS_VERSION: ${{ needs.setup.outputs.unique_tag }}
ACTIONS_EXTRA_PACKAGES: "acryl-datahub-actions[executor]==0.0.13 acryl-datahub-actions==0.0.13 acryl-datahub==0.10.5"
ACTIONS_CONFIG: "https://raw.githubusercontent.com/acryldata/datahub-actions/main/docker/config/executor.yaml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use the entrypoint from the base image, so these two env vars didn't do anything. removing them to make it more clear

run: |
./smoke-test/run-quickstart.sh
- name: Disk Check
Expand Down
Loading