New: Added support for _canShowCorrectness #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevents the component height expanding when icons are displayed - consistent with Matching and Textinput answer container spacing
- for consistency with other question items, selectable items are marked up with an aria-label consisting of correctness, selection and value. - set aria-hidden on correctness icons as correctness is covered by number aria-label instead. - apply aria-disabled to clickable slider numbers once submitted. Note, Voiceover on Mac reads numbers as 'clickable'.
ethan-lp
approved these changes
Oct 7, 2024
oliverfoster
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of adaptlearning/adapt_framework#3597
Allows option
_canShowCorrectnessinstead of_canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.New
_canShowCorrectness.show-correctnesswidget class appended for consistency with other question components. Note, there's no associated styling currently.aria-labelconsisting of correctness, selection and value.Requires
ref adaptlearning/adapt-contrib-core#582