Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #213

Merged
merged 8 commits into from
Oct 28, 2024
Merged

New: Added support for _canShowCorrectness #213

merged 8 commits into from
Oct 28, 2024

Commits on Sep 25, 2024

  1. Change classes for styling to __widget

    @kirsty-hames
    kirsty-hames committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    30d33bf View commit details
    Browse the repository at this point in the history

  2. New: Added support for _canShowCorrectness

    @kirsty-hames
    kirsty-hames committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    015f3a5 View commit details
    Browse the repository at this point in the history

  3. rtl icon display fix

    @kirsty-hames
    kirsty-hames committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2a1c3b3 View commit details
    Browse the repository at this point in the history

  4. example and readme updated

    @kirsty-hames
    kirsty-hames committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d29919c View commit details
    Browse the repository at this point in the history

  5. schemas updated

    @kirsty-hames
    kirsty-hames committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a61b4b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. preserve spacing for correctness icons when _canShowCorrectness 

    - prevents the component height expanding when icons are displayed
- consistent with Matching and Textinput answer container spacing
    @kirsty-hames
    kirsty-hames committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bef8f94 View commit details
    Browse the repository at this point in the history

  2. set correctness and selection aria on slider numbers 

    - for consistency with other question items, selectable items are marked up with an aria-label consisting of correctness, selection and value.
- set aria-hidden on correctness icons as correctness is covered by number aria-label instead.
- apply aria-disabled to clickable slider numbers once submitted. Note, Voiceover on Mac reads numbers as 'clickable'.
    @kirsty-hames
    kirsty-hames committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    767ab0b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. use correct instead of _isCorrect to set slider__number aria-label

    @kirsty-hames
    kirsty-hames committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d1c7b9a View commit details
    Browse the repository at this point in the history