Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[#222] No info to user about invalid regex #272

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

Kabowyad
Copy link
Contributor

@Kabowyad Kabowyad commented Jul 6, 2019

Recreated new branch, because i had a very bad merge/revert, which deleted tests.

Kabowyad added 4 commits July 3, 2019 19:33
- copied code to Search
- copied code from old branch
- copied code from old branch
- massive scalafmt edit
@kamilongus kamilongus self-requested a review July 7, 2019 08:39
@neongreen
Copy link
Member

Recreated new branch, because i had a very bad merge/revert, which deleted tests.

You could just force-push to the old branch.

@kamilongus
Copy link
Contributor

@Kabowyad I closed old PR. So you can now rename this PR.

@Kabowyad
Copy link
Contributor Author

Kabowyad commented Jul 7, 2019

@neongreen I thought that it will be not the best practice and also i feel confused when trying to resolve problems with git :\

@Kabowyad Kabowyad changed the title issue-222: Recreated new branch from https://github.com/aelve/codesearch/issues/222 issue-222: No info to user about invalid regex Jul 7, 2019
Kabowyad added 2 commits July 7, 2019 22:06
- format code
- removed unsed code
- fixed imports
@kamilongus kamilongus changed the title issue-222: No info to user about invalid regex [#222] No info to user about invalid regex Jul 8, 2019
- added in test new response types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants