This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
[#222] No info to user about invalid regex #272
Open
Kabowyad
wants to merge
7
commits into
develop
Choose a base branch
from
issue-222-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copied code to Search
- copied code from old branch
- copied code from old branch
- massive scalafmt edit
kamilongus
suggested changes
Jul 7, 2019
You could just force-push to the old branch. |
@Kabowyad I closed old PR. So you can now rename this PR. |
@neongreen I thought that it will be not the best practice and also i feel confused when trying to resolve problems with git :\ |
Kabowyad
changed the title
issue-222: Recreated new branch from https://github.com/aelve/codesearch/issues/222
issue-222: No info to user about invalid regex
Jul 7, 2019
- format code - removed unsed code
- fixed imports
kamilongus
changed the title
issue-222: No info to user about invalid regex
[#222] No info to user about invalid regex
Jul 8, 2019
- added in test new response types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated new branch, because i had a very bad merge/revert, which deleted tests.