Loss detection fixes #1729
Merged
Loss detection fixes #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease when heartbeats advance the high-water mark position, or it can decrease if messages arrive out of order. In both cases we want to adjust the NAK range of the receiver.
…tion to ensure the widest possible loss detection scan window. Loss detection code is concurrent to the application threads that are consuming from the image but also to the receiver thread that inserts new packets into the image and advances the high-water mark position counter. Reading that counter last ensures that we take into account all inserted packets up to this point.
… never zero. Also do not track padding bytes as the "sent bytes".
…-water mark on the receiver. A single network packet might contain multiple frames (up to an MTU). When such packet contains only `HDR_TYPE_DATA` then packet length will correspond to the combined lengths of the frames it contains. However, if there is a trailing `HDR_TYPE_PAD` packet then the packet length will not be equal to the sum of the frame sizes. For example, given a packet containing two 80 byte messages (whose aligned length is 128 bytes each) and a padding for 224 bytes. The length of the packet will be 288 bytes (256 + 32) but the "frame size" will be 512 bytes (256 + 256).
…ENGTH` and streamlining non-zero frame lookup.
vyazelenko
force-pushed
the
nak-issues
branch
from
d22a389 to
f33e0ca
Compare
…s trailing padding frame + rename method that computes the target position offset.
…will advance on next heartbeat/data frame anyway.
…fit a frame of data." This reverts commit 9b8229c.
…s almost never zero. Also do not track padding bytes as the "sent bytes"." This reverts commit 411f102.
…ild position to ensure the widest possible loss detection scan window." This reverts commit 60e6047.
…TH` and streamlining non-zero frame lookup.
…e when heartbeats advance the high-water mark position, or it can decrease if messages arrive out of order. In both cases we want to adjust the NAK range of the receiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loss detection takes into account length of the gap which can change over time, i.e. shrink when the messages are received out of order or increase if new heartbeats advance
rcv-pwmposition.