Code

Loss detection fixes#1729

Code

Merged

vyazelenko merged 14 commits intoaeron-io:masteraeron-io/aeron:masterfrom vyazelenko:nak-issuesvyazelenko/aeron:nak-issuesCopy head branch name to clipboardJan 29, 2025

+598-112

Commits

Commits on Jan 24, 2025

• [Java] Update active loss gap upon length change. Gap length can increase when heartbeats advance the high-water mark position, or it can decrease if messages arrive out of order. In both cases we …

  Show description for 0ea7049
  vyazelenko

  committed
  0ea7049

  Copy full SHA for 0ea7049

• [Java] Update offset masking code to cast the result and not the position.

  vyazelenko

  committed
  192989e

  Copy full SHA for 192989e

• [Java] Read high-water mark position after computing the rebuild position to ensure the widest possible loss detection scan window.

  Show description for 60e6047
  vyazelenko

  committed
  60e6047

  Copy full SHA for 60e6047

• [Java] Simplify sendData path by assuming that the window is almost never zero. Also do not track padding bytes as the "sent bytes".

  vyazelenko

  committed
  411f102

  Copy full SHA for 411f102

• [Java] Take into account a trailing padding frame when adjusting high-water mark on the receiver.

  Show description for 18562a7
  vyazelenko

  committed
  18562a7

  Copy full SHA for 18562a7

• [Java] Simplify term gap scanning logic by removing ALIGNED_HEADER_LENGTH and streamlining non-zero frame lookup.

  vyazelenko

  committed
  f33e0ca

  Copy full SHA for f33e0ca

Commits on Jan 27, 2025

• [Java] Add a test for rcv-hwm position update when a packet contains trailing padding frame + rename method that computes the target position offset.

  vyazelenko

  committed
  a6c9d7d

  Copy full SHA for a6c9d7d

Commits on Jan 28, 2025

• [Java] Increment snd-bpe if window is zero or too small to fit a frame of data.

  vyazelenko

  committed
  9b8229c

  Copy full SHA for 9b8229c

• [Java] Do not take into account actual padding size as the rcv-hwm will advance on next heartbeat/data frame anyway.

  vyazelenko

  committed
  1bf37d7

  Copy full SHA for 1bf37d7

Commits on Jan 29, 2025

• Revert "[Java] Increment snd-bpe if window is zero or too small to fit a frame of data."

  Show description for 063059e
  vyazelenko

  committed
  063059e

  Copy full SHA for 063059e

• Revert "[Java] Simplify sendData path by assuming that the window is almost never zero. Also do not track padding bytes as the "sent bytes"."

  Show description for ea08a3a
  vyazelenko

  committed
  ea08a3a

  Copy full SHA for ea08a3a

• Revert "[Java] Read high-water mark position after computing the rebuild position to ensure the widest possible loss detection scan window."

  Show description for 7f7f769
  vyazelenko

  committed
  7f7f769

  Copy full SHA for 7f7f769

• [C] Simplify term gap scanning logic by removing ALIGNED_HEADER_LENGTH and streamlining non-zero frame lookup.

  vyazelenko

  committed
  ff9186c

  Copy full SHA for ff9186c

• [C] Update active loss gap upon length change. Gap length can increase when heartbeats advance the high-water mark position, or it can decrease if messages arrive out of order. In both cases we wan…

  Show description for acaa061
  vyazelenko

  committed
  acaa061

  Copy full SHA for acaa061