Add support for KSP #323

rossbacher · 2021-06-25T00:35:08Z

Added support for KSP (https://github.com/google/ksp) via Rooms XProcessing library (https://github.com/androidx/androidx/tree/androidx-main/room/room-compiler-processing) as so we can still support kapt and java annotation processor.

Note: The tests are currently failing as there is a bug that causes issues with sub classes right now, still investigating this.

Few other changes:

Migrated processor and all of it's tests to Kotlin.
Move compile testing to https://github.com/tschuchortdev/kotlin-compile-testing/tree/master
Move mocking to Mockk (https://mockk.io/)
Add KTlint for processor (will add for other modules in separate PR)
Removed some old dependencies and removed need to JCenter
Added test library to show kapt setup.

…v:kotlin-compile-testing for testing. Moved all tests over and make them more meaningful by testing what ends up in the index instad of just 1:1 ow which code they generate) which with the index bing binary is unverifiable.

Removed old unused dependencies Check generated source on top of functionality Split method and class elements into two sets for processing Fixed index generation for inner classes Added processor test with inner class Enabled ksp for sample project

Fix originalting elment for Registry generation. Made unit test when running via ksp not to compiled code check.

Fix warning Updated gradle to 7.1

Clean up gralde plugin dependency for ksp. Updated documentation.

Remove airbnb repo dependency

Also add ktlint to ci checks.

…et the custom processors from config. Use testKsp to test that behavior.

BenSchwab

Awesome - thanks for all the Koltin conversions, setting up ktlint and mockk! I'll take a look at the inner class error and see if I have any insight

README.md

...linkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/DeepLinkAnnotatedElement.kt

deeplinkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/DeepLinkProcessor.kt

BenSchwab · 2021-06-25T02:12:41Z

README.md

+
+```groovy
+ksp {
+  arg("deepLink.incremental", "true")


How do you feel about removing the non incremental option? Looking through this PR, it would reduces complexity, and really everyone should want to use incremental.

I just wanted to keep it backwards compatible. It would imho not reduce complexity by that much. But it can be on the chopping block if it does not fit with any other major changes.

deeplinkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/DeepLinkProcessor.kt

deeplinkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/Documentor.kt

...inkdispatch-processor/src/test/java/com/airbnb/deeplinkdispatch/BaseDeepLinkProcessorTest.kt

deeplinkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/DeepLinkProcessor.kt

rossbacher · 2021-06-25T22:42:26Z

Awesome - thanks for all the Koltin conversions, setting up ktlint and mockk! I'll take a look at the inner class error and see if I have any insight

@BenSchwab I created an issue ticket with ksp here google/ksp#492 for the inner class error.

Adde Kotlin source base tests. Cleanup/fixes

… done for room (mentioned here tschuchortdev/kotlin-compile-testing#105 (comment)) but this also does not work. Disabled ksp test for inner classes in java because of tschuchortdev/kotlin-compile-testing#105

Add Kotlin based module

BenSchwab

🎉

BenSchwab · 2021-06-29T20:35:56Z

README.md

+
+When using Kotlin we strongly suggest to use KSP as it can bring major speed improvements.
+We ran into issues when enabling KSP on a project while the Kapt plugin was still applied.
+If you want to both use Kapt and KSP processors on the same project be careful and expect


I wonder how much of this was just caused by the no java sources issues - Eli talked a bit more to the KSP team, and running both kapt and ksp should be fine, so long as no kapt processor depends on the ksp generated sources

Yeah, I wanted to remove this actually, thx for pointing it out.

Andreas Rossbacher added 22 commits June 15, 2021 13:43

Rename .java to .kt

bc3f409

Convert processor ot Kotlin

01cb043

Rename .java to .kt

575714a

Cleanup

474a00c

Kotlin conversion cleanup and segmentation.

e3e4ed4

First step of ksp conversion

e56bcb8

First step of ksp conversion

138ebcc

Fix delegate and index generation

181aa9c

Cleanup

fc2714e

Moved all tests to mockk

a8588a5

Removed old unused dependencies Check generated source on top of functionality Split method and class elements into two sets for processing Fixed index generation for inner classes Added processor test with inner class Enabled ksp for sample project

Fix originating elements for Delegate generation.

d828dfc

Fix originalting elment for Registry generation. Made unit test when running via ksp not to compiled code check.

Use | for separator of options

b8a023c

Fix argument and disable kapt plugin

ec8ee63

Remove no unused jcenter

8f3ea81

Fix warning Updated gradle to 7.1

Add Kapt test library to show setup for kapt.

655a4ad

Clean up gralde plugin dependency for ksp. Updated documentation.

Use public version of xProcessorVersion

a21fda2

Remove airbnb repo dependency

Add ktlint plugin and clean up the processor.

d01619e

Also add ktlint to ci checks.

Better error message match.

9149fe6

When running ksp allow the incremental flag to not be set and still g…

cda0540

…et the custom processors from config. Use testKsp to test that behavior.

Cleanup.

0adc53a

Typos

b2f9223

BenSchwab reviewed Jun 25, 2021

View reviewed changes

deeplinkdispatch-processor/src/main/java/com/airbnb/deeplinkdispatch/DeepLinkProcessor.kt Show resolved Hide resolved

Andreas Rossbacher added 5 commits June 25, 2021 17:19

Cleanup and Pr comments.

a106b85

Rename .java to .kt

feea144

Made DeepLinkAnnotatedElement a sealed class

cbfa593

Adde Kotlin source base tests. Cleanup/fixes

Enable failing tests

3df985c

Kotlin conversion

1733fcd

Andreas Rossbacher added 3 commits June 29, 2021 13:00

Make sure to generate java source files in correct package like it is…

872847d

… done for room (mentioned here tschuchortdev/kotlin-compile-testing#105 (comment)) but this also does not work. Disabled ksp test for inner classes in java because of tschuchortdev/kotlin-compile-testing#105

Add missing import

c36b3af

Add Kotlin based module

Add note about Kotlin source files when using KSP.

e9e792d

BenSchwab approved these changes Jun 29, 2021

View reviewed changes

Remove note about kapt/ksp coexistance.

87f5348

rossbacher merged commit 218c162 into master Jun 29, 2021

rossbacher deleted the supportKsp branch June 29, 2021 20:56

elihart mentioned this pull request Aug 19, 2021

Support KSP #307

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for KSP #323

Add support for KSP #323

rossbacher commented Jun 25, 2021 •

edited

Loading

BenSchwab left a comment

BenSchwab Jun 25, 2021

rossbacher Jun 25, 2021

rossbacher commented Jun 25, 2021

BenSchwab left a comment

BenSchwab Jun 29, 2021

rossbacher Jun 29, 2021

Add support for KSP #323

Add support for KSP #323

Conversation

rossbacher commented Jun 25, 2021 • edited Loading

BenSchwab left a comment

Choose a reason for hiding this comment

BenSchwab Jun 25, 2021

Choose a reason for hiding this comment

rossbacher Jun 25, 2021

Choose a reason for hiding this comment

rossbacher commented Jun 25, 2021

BenSchwab left a comment

Choose a reason for hiding this comment

BenSchwab Jun 29, 2021

Choose a reason for hiding this comment

rossbacher Jun 29, 2021

Choose a reason for hiding this comment

rossbacher commented Jun 25, 2021 •

edited

Loading