Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KSP #323
Add support for KSP #323
Changes from all commits
bc3f409
01cb043
575714a
e16e5ba
474a00c
e3e4ed4
e56bcb8
138ebcc
181aa9c
fc2714e
a8588a5
d828dfc
b8a023c
ec8ee63
8f3ea81
655a4ad
a21fda2
d01619e
9149fe6
cda0540
0adc53a
b2f9223
a106b85
feea144
cbfa593
3df985c
1733fcd
872847d
c36b3af
e9e792d
87f5348
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about removing the non incremental option? Looking through this PR, it would reduces complexity, and really everyone should want to use incremental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to keep it backwards compatible. It would imho not reduce complexity by that much. But it can be on the chopping block if it does not fit with any other major changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you thinking we should handle the fact that xProcessor is still in alpha, and ksp in beta for the public release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could release a DLD next major version beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the feature in the next release For this one it does not make that much sense dropping it as itis all working already. And yes this tests incremental compilation.
This file was deleted.