Set LeaseIPStatus json tags to keep consistency #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troian
reviewed
Dec 7, 2022
| Protocol string | ||
| IP string | ||
| Port uint32 `json:"port"` | ||
| ExternalPort uint32 `json:"external_port"` |
There was a problem hiding this comment.
this is potentially breaking change as the default values are different
https://go.dev/play/p/nh3PaU5Qatb
There was a problem hiding this comment.
These are breaking changes indeed, but they make the whole object consistent in terms of casing which is an overall improvement and might be worth to include in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the json tags for LeaseIPStatus type.
Is there any reason to not use the net.IP type for the IP?