Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LeaseIPStatus json tags to keep consistency #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set LeaseIPStatus json tags to keep consistency #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gateway/rest/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import (
)

type LeasedIPStatus struct {
Port uint32
ExternalPort uint32
Protocol string
IP string
Port uint32 `json:"port"`
ExternalPort uint32 `json:"external_port"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is potentially breaking change as the default values are different
https://go.dev/play/p/nh3PaU5Qatb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are breaking changes indeed, but they make the whole object consistent in terms of casing which is an overall improvement and might be worth to include in a future release.

Protocol string `json:"protocol"`
IP string `json:"ip"`
}

type LeaseStatus struct {
Expand Down