Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Akka HTTP 10.2.0 #893

Merged
merged 16 commits into from
May 4, 2021
Merged

Bump Akka HTTP 10.2.0 #893

merged 16 commits into from
May 4, 2021

Conversation

ignasi35
Copy link
Contributor

@ignasi35 ignasi35 commented May 3, 2021

Refs #866

As part of this PR:

@ignasi35 ignasi35 requested review from raboof and jrudolph May 3, 2021 10:36
@raboof
Copy link
Contributor

raboof commented May 3, 2021

also needs scalafmt

Copy link
Contributor

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions below

@ignasi35
Copy link
Contributor Author

ignasi35 commented May 3, 2021

I wasn't too sure about making PemManagersProvider public, TBH. Given your comments I've rolled it back to private[akka].

the most important tests in this build are the integration tests with K8s.

@raboof raboof force-pushed the bump-akka-http-10.2 branch from d49c819 to 0661a9c Compare May 4, 2021 08:56
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@raboof raboof merged commit 1e83485 into master May 4, 2021
@raboof raboof deleted the bump-akka-http-10.2 branch May 4, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants