-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Akka HTTP 10.2.0 #893
Conversation
...-kubernetes-api/src/main/scala/akka/discovery/kubernetes/KubernetesApiServiceDiscovery.scala
Outdated
Show resolved
Hide resolved
...ubernetes/src/main/scala/akka/coordination/lease/kubernetes/internal/KubernetesApiImpl.scala
Outdated
Show resolved
Hide resolved
management-pki/src/main/scala/akka/pki/kubernetes/PemManagersProvider.scala
Outdated
Show resolved
Hide resolved
also needs scalafmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions below
management/src/main/scala/akka/management/scaladsl/AkkaManagement.scala
Outdated
Show resolved
Hide resolved
management-pki/src/main/scala/akka/pki/kubernetes/PemManagersProvider.scala
Outdated
Show resolved
Hide resolved
...ter/bootstrap/contactpoint/ClusterBootstrapRetryUnreachableContactPointIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
...t/scala/akka/management/cluster/bootstrap/contactpoint/ClusterBootstrapIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
...a/akka/management/cluster/bootstrap/contactpoint/ClusterBootstrapExistingSeedNodesSpec.scala
Outdated
Show resolved
Hide resolved
...agement/cluster/bootstrap/contactpoint/ClusterBootstrapDiscoveryBackoffIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
I wasn't too sure about making the most important tests in this build are the integration tests with K8s. |
Co-authored-by: Johannes Rudolph <[email protected]>
d49c819
to
0661a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Refs #866
As part of this PR:
-Xfatal-warnings
.AkkaSslConfig
with the newakka-managment-pki
which is inspired byakka-pki
. This new module could eventually be promoted to Akka code or Akka HTTP as part of Explore how to reduce the TLS setup akka-http#3772