-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress logging from repo server #206
Conversation
Signed-off-by: Kent <[email protected]>
✅ Deploy Preview for docs-kargo-render-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 38.28% 38.28%
=======================================
Files 19 19
Lines 1157 1157
=======================================
Hits 443 443
Misses 697 697
Partials 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to surpressing logging as a default, which I think we should do, another common technique that I think we should do is logging to stderr instead of stdout. The parseable output would continue going to stdout. In fact, this is what kubectl does.
So you could do:
kubectl get pods -o json -v=6
The pod json would be to stdout, but the log messages would go to stderr:
I1023 15:37:26.181218 12126 loader.go:374] Config loaded from file: /Users/jesse/.kube/config
I1023 15:37:26.937120 12126 round_trippers.go:553] GET https://mycluster.com/api/v1/namespaces/default/pods?limit=500 200 OK in 749 milliseconds
I'll approve this PR for the log level reduction. Feel free to create a different issue or PR for switching to stderr for log output.
I had that thought as well. Since you like it also, yes... I'll open an issue for it. |
Signed-off-by: Kent Rancourt <[email protected]>
@alexmt you might be the best person to review this.
This is a prereq for akuity/kargo#951