Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow 307/308 redirects (1.x backport) #253

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Follow 307/308 redirects (1.x backport) #253

merged 2 commits into from
Dec 5, 2020

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Nov 23, 2020 •
edited
Loading

This backports #252 to the 1.x branch. I confirmed locally that this fixes the deadlinks issue (deadlinks/cargo-deadlinks#110).

@jyn514 jyn514 changed the title Follow 307/308 redirects Follow 307/308 redirects (1.x backport) Nov 23, 2020
@jyn514 jyn514 mentioned this pull request Nov 27, 2020
Closed
@jyn514
Copy link
Contributor Author

jyn514 commented Dec 5, 2020

Updated this with the changes from #252 :) It's missing the new documentation from 7def5a8 and 82e8338 since testserver.rs was only added in the 2.x branch, but I think that's ok since hopefully 2.x will have a release soon.

algesten
algesten approved these changes Dec 5, 2020
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Let's go!

@algesten algesten merged commit 7d4f794 into algesten:1.x Dec 5, 2020
@jyn514 jyn514 deleted the 1.x branch December 5, 2020 14:51
@jyn514 jyn514 mentioned this pull request Dec 6, 2020
Merged
jsha pushed a commit that referenced this pull request Dec 6, 2020
@jyn514
[1.x] Fix broken behavior for 308 redirects (#274)
23f9b47 
Previously, this would unconditionally panic:

```
thread '<unnamed>' panicked at 'attempt to subtract with overflow', /home/joshua/src/rust/ureq/src/unit.rs:244:59
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```

Follow-up to #253. Sorry for not testing earlier!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @algesten