Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to use a virtualenv as own python #5661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ktf
Copy link
Member

@ktf ktf commented Oct 15, 2024

Notice that it will still try to install our own provided
packages so that we have a minimum working environment.

@ktf ktf requested a review from a team as a code owner October 15, 2024 13:14
@ktf
Copy link
Member Author

ktf commented Oct 15, 2024

@aalkin @singiamtel @pzhristov @ddobrigk @adriansev This allows alibuild to reuse an already existing virtualenv which is active at the moment of the build.

@singiamtel
Copy link
Collaborator

singiamtel commented Oct 15, 2024

Would this cause trouble with the other packages that try to handle venvs? Namely xjalienfs (just saw the full diff) and machinelearninghep

@ktf
Copy link
Member Author

ktf commented Oct 15, 2024

In principle no, they will just install as usual and think that python comes from the virtualenv. It's however a good idea to add similar support also for anything which tries to install python packages. Once https://github.com/alisw/alibuild/pull/875/files is merged, we can even automate the rebuilds if one of the tools changes.

Notice that it will still try to install our own provided
packages so that we have a minimum working environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants