FIx incorrect dates in 'Get involved' page #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
92cc6b9 to
f62032c
Compare
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
f62032c to
69ea3cd
Compare
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
69ea3cd to
00b9663
Compare
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
00b9663 to
c97f884
Compare
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
c97f884 to
c7aa8e0
Compare
spec/system/get_involved_spec.rb
Outdated
| @@ -35,6 +35,14 @@ | |||
| it "does not display a single page notification button" do | |||
| expect(page).not_to have_css(".gem-c-single-page-notification-button") | |||
| end | |||
|
|
|||
| it "shows opening date" do | |||
There was a problem hiding this comment.
I think this needs to be something like "shows when it was last updated" or other name that aligns with what we check.
There was a problem hiding this comment.
Yes, I forgot to change that from the previous version. I'll fix it in a minute.
unoduetre
force-pushed
the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
from
c7aa8e0 to
783c92f
Compare
catalinailie
approved these changes
Feb 17, 2025
unoduetre
deleted the
3259-incorrect-dates-for-consultations-on-get-involved-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The get involved page on gov.uk includes a 'Engage with government' section which lists recently opened consultations and consultations with recent outcomes.
The dates in these 2 sections ('Recently opened' and 'Recent outcomes') next to the department acronym (not the 'Closes'/'Closed' date) doesn't seem to relate to the document at all - either when it was first published or last updated.
Why
Trello card
Testing
Before
https://www.gov.uk/government/get-involved
After
https://govuk-frontend-app-pr-4638.herokuapp.com/government/get-involved