Swap jasmine gem for new runner #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jasmine ruby gem is deprecated: https://github.com/jasmine/jasmine-gem?tab=readme-ov-file#discontinued PhantomJS, the headless webkit browser used by the Jasmine gem, is no longer being worked on: https://phantomjs.org/ This follows the guidance in the Jasmine docs and replaces the gem and phantomJS with the jasmine-browser-runner npm package. Because the new setup isn't in ruby, dependencies 'required' in JS files now need to be included manually in the config.
tombye
changed the title
tombye
changed the title
tombye
force-pushed
the
swap-jasmine-gem-for-new-runner
branch
from
0faed4c to
a963cd0
Compare
We don't get a jasmine rake task so need to create one in the Rakefile.
tombye
force-pushed
the
swap-jasmine-gem-for-new-runner
branch
from
a963cd0 to
87a5284
Compare
tombye
changed the title
Open
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 16, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
added a commit
that referenced
this pull request
Jan 17, 2025
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s changed
The way we run the JS tests currently relies on 2 defunct technologies:
This swaps them out for the
jasmine-browser-runnernpm package to manage the jasmine part and google chrome to run them.Identifying a user need
A recent pull request's tests failed when building phantomjs on the latest ubuntu. I don't know enough about C to diagnose the exact cause but no one is maintaining phantomjs so any fixes are unlikely.
This doesn't meet a need in itself but any pull requests that do can't currently be merged and this should unblock that.