some work on the install script

[amtoine]

This PR should address most of the points in #35.

[amtoine]

changelog

see git diff 1e6ca0e^..ceeee65 or the diff on GitHub

here, i fixed most of the points in #35 and refactored the script into functions

see git diff 6bf4098^..e46bb21 or the diff on GitHub

here, i refactored all the hardcoded values into constants at the top and created lists of things to iterate over them and avoid redundant code, such as the ./install.sh x86_64/... or sudo systemctl enable ...

see git diff 842a8da^..31a8bdc or the diff on GitHub

in these last changes, i tried to fix bugs that occured in a VM, mainly typos and pulling the files at the right places for now 👍

remaining bugs to be fixed and features to be implemented

• the names of the packages are not correct and thus fail the install, without stopping
  should be addressed in fix the name of the packages from pkgbuilds#25 #67
• the cargo dependencies do not install properly
  work is to be done in the install_dependencies function
• the remaining points in some ideas and bugs (?) in install.sh #35

[amtoine]

changelog

see git diff f25476e^..b7fc147 or the diff on GitHub

regarding #35 itself

• i could not find the problematic files i talk about in the last comment of some ideas and bugs (?) in install.sh #35, i won't implement the feature
• thanks to the early quitting on any error i've implemented, i think a log file is not usefull here

the changes

in the order that they appear in the f25476e^..b7fc147 above

• the dependencies are quite hard to install right now...
  i've hardcoded the mandatory packages for the GOAT system to launch and disabled the installation from pkgs.toml.
  see conclusion below
• system files from .system/ are installed in /
• a new echo_and_run to run commands but see them clearly at the same time
  • this function exits when the command given to it fails
  • subshell, i.e. for the pkgbuilds and dmenu take that error code and propagate the error
    the result of this is that install.sh now quits on any error 👍

conclusion

apart from the missing dependencies, i've tried the script in a VM and it runs until completion 👌

• could you try to run it as well @atxr?

there sould be an error on the paru packages, as the name is not correct anymore 👉 this is addressed in #67 and applying the same changes works fine as well 👍

after that, the script should work fine and print a 🟢 message at the end 🎉
you can reboot and have an incomplete system, but running 👍

things like dmscripts, ghq, ..., are missing
i would like to fix all of these dependency issues once and for all in #43, and leave the script as-is for now 😌

[atxr]

I read the script and it looks very good at first sight.
I have several problems with VM currently so I cannot try to run it right now, but I will do it soon on another computer.

[amtoine]

I read the script and it looks very good at first sight.

noice 😋

I have several problems with VM currently so I cannot try to run it right now, but I will do it soon on another computer.

no worries, let's take some time to test this 😉

[amtoine]

@atxr
i've launched a vanilla Arch Linux VM and recorded the installation

disclaimers

• due to the reduced size of the VM, i was not able to install our goat-wallpapers-git, too big for the VM partition...
  to mitigate this size issue with other wallpaper-related packages and as paru is veeeeery long to compile, i've applied the following diff to the install.sh script

diff --git a/install.sh b/install.sh
index 7bf3ba2..37aa3b8 100644
--- a/install.sh
+++ b/install.sh
@@ -42,14 +42,10 @@ REMOTE_PKGBUILDS="https://github.com/goatfiles/pkgbuilds"
 LOCAL_PKGBUILDS_DIR="/tmp/pkgbuilds"
 
 PKGBUILDS=(
-    goat-paru-git
     goat-scripts-git
     goat-sounds-git
-    goat-wallpapers-git
     goat-applications-git
     goat-icons-git
-    goat-junnunkarim-wallpapers-git
-    goat-mut-ex-wallpapers-git
 )
 
 SYSTEM_FILES=(

• because the script, as mentionned above, won't install all the dependencies for now, some minor parts of the config are broken, e.g. the font in the terminal
• i had to make a small change to the script due to FEATURE: remove all the system files #80 -> see 2515989

the rushes

conlusion

in the end... it works 🎉

minor things broken, but sddm is here, as well as a wallpaper!
bspwm and sxhkd allow to open and manage windows.
alacritty and nushell are working 👌

[atxr]

Awesome work! That's very clean!
Would you like me to test? I mean if you tested on a fresh VM that sounds good for me!

[amtoine]

Awesome work! That's very clean!

😋

Would you like me to test? I mean if you tested on a fresh VM that sounds good for me!

here's what we can do:

• try to test this is a VM, possibly by removing the big dependencies such as goat-paru-git and goat-wallpapers-git, during the afternoon
• if you do not have the time and do not post anything here by, let's say, 6 PM, i'll merge
• otherwise, you might be able to catch a few more things to change before merging 😌

sounds good? 😏

[amtoine]

it's been 24+h since yesterday so, ready or not, here it comes 💪