SPI Engine: SDO data prefetch #1501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
LBFFilho
force-pushed
the
spi_sdo_prefetch
branch
5 times, most recently
from
188d0a7 to
1840af0
Compare
LBFFilho
force-pushed
the
spi_sdo_prefetch
branch
2 times, most recently
from
e6937d4 to
4f982aa
Compare
LBFFilho
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
podgori and
ladace
as code owners
gastmaier
reviewed
Nov 19, 2024
dlech
reviewed
Nov 20, 2024
SDO data can now be clocked in independently from the offload trigger. This allows lower latencies for executing transfers, since the data can be obtained from the DMA before the trigger. It also better separates the command path from the data path. SDO data source behavior is altered: previously, with SDO_STREAMING=1 the SPI Engine would prioritize the SDO memory and switch to AXI Streaming when empty. This unused automatic switching is now removed: if the SPI Engine is built with SDO_STREAMING=1 it will only get SDO data from AXI Streaming, and with SDO_STREAMING=0 it will only use the SDO memory. Signed-off-by: Laez Barbosa <[email protected]>
LBFFilho
force-pushed
the
spi_sdo_prefetch
branch
from
4f982aa to
d845ac3
Compare
|
changed it so the SDO data source is a parameter (synthesis-time), rebased on main |
|
Tested on AD4052 with cora, same behavior as in main |
|
ad4052_ardz.de10nano jenkins build fails with this error |
Signed-off-by: Laez Barbosa <[email protected]>
LBFFilho
requested review from
acostina,
AndreiGrozav and
PopPaul2021
as code owners
Signed-off-by: Laez Barbosa <[email protected]>
Signed-off-by: sarpadi <[email protected]>
gastmaier
requested changes
Jan 24, 2025
| @@ -322,6 +304,18 @@ module spi_engine_offload #( | |||
| end | |||
| end | |||
|
|
|||
| always @(posedge spi_clk ) begin | |||
There was a problem hiding this comment.
Suggested change
| always @(posedge spi_clk ) begin | |
| always @(posedge spi_clk) begin |
| @@ -13,3 +13,5 @@ ad_ip_parameter rom_sys_0 CONFIG.PATH_TO_FILE "$mem_init_sys_file_path/mem_init_ | |||
| ad_ip_parameter rom_sys_0 CONFIG.ROM_ADDR_BITS 9 | |||
|
|
|||
| sysid_gen_sys_init_file | |||
|
|
|||
| set_property strategy Performance_Retiming [get_runs impl_1] | |||
There was a problem hiding this comment.
This usually goes in the system_project.tcl not _db (28 _project.tcl vs 2 _bd.tcl)
| @@ -95,7 +95,7 @@ module spi_engine_offload #( | |||
| localparam SDO_SOURCE_MEM = 1'b0; | |||
|
|
|||
| reg spi_active = 1'b0; | |||
| reg sdo_source_select = SDO_SOURCE_MEM; | |||
| wire sdo_source_select; | |||
There was a problem hiding this comment.
Move to wires section of file?
| @@ -111,10 +111,12 @@ module spi_engine_offload #( | |||
| wire [CMD_MEM_ADDRESS_WIDTH-1:0] spi_cmd_rd_addr_next; | |||
| wire spi_enable; | |||
| wire trigger_posedge; | |||
| reg sdo_mem_valid; | |||
There was a problem hiding this comment.
Move to reg section of file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Allows spi_engine_execution get sdo data independently of the instruction command. This reduces the trigger to transfer latency, and opens the door to further pipelining this path or reducing latency even more.
(this PR should be merged after #1499)
PR Type
PR Checklist