Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spi_engine testbench: update for hdl spi_engine v1.4.0 #167

Merged
merged 1 commit into from
Feb 3, 2025
Merged

spi_engine testbench: update for hdl spi_engine v1.4.0 #167

merged 1 commit into from
Feb 3, 2025

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Jan 29, 2025 •
edited
Loading

PR Description

Updates SPI Engine tests to reflect changes on HDL and introduces simple improvements used to develop the HDL:

  • separate cfgs for the 4 SPI modes
  • a new test_slowdata test program

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • New test (change that adds new test program and/or testbench)
  • Breaking change (has dependencies in other repositories/testbenches)
  • Documentation (change that adds or modifies documentation)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have ran all testbenches affected by this PR
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Errors on compilation/elaboration/simulation
  • I have set the verbosity level to none for the test program

@IstvanZsSzekely IstvanZsSzekely added the enhancement New feature or request label Jan 30, 2025
@IstvanZsSzekely IstvanZsSzekely changed the title spi_engine: update for hdl 1.4.0 spi_engine testbench: update for hdl spi_engine v1.4.0 Jan 30, 2025
@LBFFilho LBFFilho force-pushed the spi_sdo_prefetch branch 2 times, most recently from 673b70a to 5959ff7 Compare January 30, 2025 13:03
@LBFFilho LBFFilho merged commit 54b1cd6 into main Feb 3, 2025
2 checks passed
@LBFFilho LBFFilho deleted the spi_sdo_prefetch branch February 3, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IstvanZsSzekely IstvanZsSzekely IstvanZsSzekely approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LBFFilho @IstvanZsSzekely