Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Inputs.connect and handle ambiguous connections #2053

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 4, 2025

The current Inputs.connect method tries to connect an object to an input pin accepting the object type.
This worked when only one input accepted a certain type, and raised an error about ambiguity when several were available.
This effectively prevents from having operators with two inputs accepting a same type.

This PR changes the current behavior in two ways:

  • it allows for operators with two inputs accepting a same type to use this method to ensure retro-compatibility of scripts, and it picks the first input found accepting the type, raising a warning instead of an errror.
  • it marks the Inputs.connect method as deprecated in favor of explicit output-to-input connections.

@PProfizi PProfizi added deprecation Adds a deprecation bug Something isn't working labels Feb 4, 2025
@PProfizi PProfizi self-assigned this Feb 4, 2025
@PProfizi PProfizi added this to the 0.13.5 milestone Feb 4, 2025
@PProfizi PProfizi changed the title Maint/test inputs connect fix for daily update Deprecate Inputs.connect and handle ambiguous connections Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (b673c4f) to head (17c5ad3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.03%     
==========================================
  Files          90       90              
  Lines       10225    10231       +6     
==========================================
+ Hits         9055     9058       +3     
- Misses       1170     1173       +3     

@PProfizi PProfizi changed the base branch from maint/update_code_for_252_daily_on_master to master February 4, 2025 13:35
@PProfizi PProfizi requested a review from a team as a code owner February 4, 2025 13:35
@PProfizi PProfizi force-pushed the maint/test_inputs_connect_fix_for_daily_update branch from 193482e to ef7f729 Compare February 4, 2025 13:37
@PProfizi PProfizi merged commit 06567a3 into master Feb 4, 2025
44 of 46 checks passed
@PProfizi PProfizi deleted the maint/test_inputs_connect_fix_for_daily_update branch February 4, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation Adds a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants