-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-37669: [C++][Python] Fix casting to extension type with fixed size…
… list storage type (#42219) ### Rationale for this change Casting to an extension type with fixed-size list storage type was segfaulting. The underlying issue was a debug check in the casting kernel in the code path about pre-allocated data, but in this case we shouldn't be pre-allocating anything, because "cast to extension type" _can_ be zero copy, and we should let that be handled by the underlying cast to the storage type. ### What changes are included in this PR? Specifically mark the cast kernels to extension type as `NullHandling::COMPUTED_NO_PREALLOCATE` and `MemAllocation::NO_PREALLOCATE` ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #37669 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Will Jones <[email protected]>
- Loading branch information
1 parent
f07d442
commit 541647a
Showing
2 changed files
with
63 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters