GH-39919: [C++][Dataset] Add missing Protobuf static link dependency #40015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used.
|
@github-actions crossbow submit java-jars |
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
Revision: 62c750d Submitted crossbow builds: ursacomputing/crossbow @ actions-f7a2fd829d
|
|
Worked: #39919 (comment) |
raulcd
reviewed
Feb 9, 2024
github-actions
bot
added
awaiting changes
|
My idea: #39919 (comment) |
github-actions
bot
added
awaiting merge
|
Thanks @kou for working on this 👍 |
vibhatha
approved these changes
Feb 10, 2024
felipecrv
approved these changes
Feb 10, 2024
kou
commented
Feb 10, 2024
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit f7dc37f. There were 2 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…dency (apache#40015) ### Rationale for this change We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used. If we don't link system libprotobuf.a, some symbols are missing. ### What changes are included in this PR? Add missing `${ARROW_PROTOBUF_LIBPROTOBUF}` to `ARROW_STATIC_INSTALL_INTERFACE_LIBS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39919 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…dency (apache#40015) ### Rationale for this change We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used. If we don't link system libprotobuf.a, some symbols are missing. ### What changes are included in this PR? Add missing `${ARROW_PROTOBUF_LIBPROTOBUF}` to `ARROW_STATIC_INSTALL_INTERFACE_LIBS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39919 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…dency (apache#40015) ### Rationale for this change We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used. If we don't link system libprotobuf.a, some symbols are missing. ### What changes are included in this PR? Add missing `${ARROW_PROTOBUF_LIBPROTOBUF}` to `ARROW_STATIC_INSTALL_INTERFACE_LIBS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39919 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
Mar 12, 2024
…40015) ### Rationale for this change We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used. If we don't link system libprotobuf.a, some symbols are missing. ### What changes are included in this PR? Add missing `${ARROW_PROTOBUF_LIBPROTOBUF}` to `ARROW_STATIC_INSTALL_INTERFACE_LIBS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #39919 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to link system libprotobuf.a too when we link libarrow.a, ORC is enabled and system Protobuf is used.
If we don't link system libprotobuf.a, some symbols are missing.
What changes are included in this PR?
Add missing
${ARROW_PROTOBUF_LIBPROTOBUF}toARROW_STATIC_INSTALL_INTERFACE_LIBS.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.