-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [C#] Handle Empty Schema #42132
MINOR: [C#] Handle Empty Schema #42132
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@CurtHagenlocher When can we expect the next release, this issue is a blocker. |
Arrow releases roughly every three months. The next release is expected at the beginning of August. |
Can you do minor release sooner to include this fix? |
At this time, there's no way to publish a build of just the C# components. An out-of-band release of Arrow (i.e. a "dot one") is quite a heavy process -- effectively the same work as a full release -- and so it's typically reserved for regressions from a previous release. If it turns out that there is a 16.2, I can propose this as a candidate for inclusion. |
Sure, sounds good. |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3333648. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
While developing SDK encountered this error:
The issue is the schema buffer is empty, and other libraries don't throw the error in this case. This PR makes this consistent with libraries for other languages.
What changes are included in this PR?
Return null if Schema buffer is empty.
Are these changes tested?
Tested against our Flight API.
Are there any user-facing changes?
Fix critical bug this inability to run request against flight service, which doesn't return schema in GetFlightInfo.