feat: add read array support #1456
Open
+85
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Feb 27, 2025
| SQLConf.USE_V1_SOURCE_LIST.key -> "parquet", | ||
| CometConf.COMET_ENABLED.key -> "true", | ||
| CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "false", | ||
| CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_DATAFUSION) { |
There was a problem hiding this comment.
It would be good to also test with SCAN_NATIVE_ICEBERG_COMPAT
There was a problem hiding this comment.
@andygrove can we do this in follow up PR? I'm not sure if for iceberg its needed to create an iceberg table?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
============================================
+ Coverage 56.12% 58.57% +2.44%
- Complexity 976 1016 +40
============================================
Files 119 122 +3
Lines 11743 12250 +507
Branches 2251 2305 +54
============================================
+ Hits 6591 7175 +584
+ Misses 4012 3919 -93
- Partials 1140 1156 +16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1454 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?