-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add read array support #1456
Open
comphead
wants to merge
6
commits into
apache:main
Choose a base branch
from
comphead:dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−16
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
90a67a6
feat: add read array support
comphead 370e386
feat: add read array support
comphead c9531be
feat: add read array support
comphead 5365e59
feat: add read array support
comphead 37bb978
feat: add read array support
comphead 2491e23
feat: add read array support
comphead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
spark/src/test/scala/org/apache/comet/exec/CometNativeReaderSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.comet.exec | ||
|
||
import scala.reflect.runtime.universe._ | ||
|
||
import org.scalactic.source.Position | ||
import org.scalatest.Tag | ||
|
||
import org.apache.spark.sql.CometTestBase | ||
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper | ||
import org.apache.spark.sql.internal.SQLConf | ||
|
||
import org.apache.comet.CometConf | ||
|
||
class CometNativeReaderSuite extends CometTestBase with AdaptiveSparkPlanHelper { | ||
override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit | ||
pos: Position): Unit = { | ||
super.test(testName, testTags: _*) { | ||
withSQLConf( | ||
CometConf.COMET_EXEC_ENABLED.key -> "true", | ||
SQLConf.USE_V1_SOURCE_LIST.key -> "parquet", | ||
CometConf.COMET_ENABLED.key -> "true", | ||
CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "false", | ||
CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_DATAFUSION) { | ||
testFun | ||
} | ||
} | ||
} | ||
|
||
test("native reader - read simple struct fields") { | ||
testSingleLineQuery( | ||
""" | ||
|select named_struct('firstName', 'John', 'lastName', 'Doe', 'age', 35) as personal_info union all | ||
|select named_struct('firstName', 'Jane', 'lastName', 'Doe', 'age', 40) as personal_info | ||
|""".stripMargin, | ||
"select personal_info.* from tbl") | ||
} | ||
|
||
test("native reader - read simple array fields") { | ||
testSingleLineQuery( | ||
""" | ||
|select array(1, 2, 3) as arr union all | ||
|select array(2, 3, 4) as arr | ||
|""".stripMargin, | ||
"select arr from tbl") | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also test with
SCAN_NATIVE_ICEBERG_COMPAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andygrove can we do this in follow up PR? I'm not sure if for iceberg its needed to create an iceberg table?