Use 2 partitions in planner tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Oct 4, 2024
| @@ -394,8 +394,8 @@ mod test { | |||
|
|
|||
| let file = format!("testdata/queries/q{n}.sql"); | |||
| let sql = fs::read_to_string(&file)?; | |||
| let config = SessionConfig::new().with_target_partitions(1); | |||
| let ctx = SessionContext::with_config(config); | |||
| let config = SessionConfig::new().with_target_partitions(2); | |||
There was a problem hiding this comment.
This is the main change
edmondop
reviewed
Oct 4, 2024
| @@ -145,26 +145,6 @@ export TPCH_DATA_PATH=`pwd`/data | |||
| cargo test | |||
| ``` | |||
|
|
|||
| Tests compare plans with expected plans, which unfortunately contain the | |||
There was a problem hiding this comment.
If this is not needed anymore, can we also remove the script ?
There was a problem hiding this comment.
It was removed in my previous PR, but I missed this documentation
There was a problem hiding this comment.
Ooops, my previous review was not deep enough
edmondop
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 2 partitions so that we have distributed plans with multiple query stages