-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Allow long paths in windows CLI build #15840
Merged
gregnazario
merged 3 commits into
aptos-labs:main
from
gregnazario:fix-windows-cli-builds
Jan 29, 2025
Merged
[cli] Allow long paths in windows CLI build #15840
gregnazario
merged 3 commits into
aptos-labs:main
from
gregnazario:fix-windows-cli-builds
Jan 29, 2025
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 44m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
gregnazario
force-pushed
the
fix-windows-cli-builds
branch
from
January 29, 2025 05:17
f579b7f
to
372ed77
Compare
banool
approved these changes
Jan 29, 2025
gregnazario
force-pushed
the
fix-windows-cli-builds
branch
from
January 29, 2025 06:01
372ed77
to
ae6ac0a
Compare
banool
approved these changes
Jan 29, 2025
perryjrandall
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank u ser
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows build of CLI is broken, this fixes it
Error is that the paths are "too long" for Windows defaults.
Stack overflow fix:
https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows
How Has This Been Tested?
https://github.com/gregnazario/aptos-core/actions/runs/13025511981
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist