Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Allow long paths in windows CLI build #15840

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Jan 29, 2025

Description

Windows build of CLI is broken, this fixes it

Error is that the paths are "too long" for Windows defaults.

error: failed to get `aptos-moving-average` as a dependency of package `aptos-indexer-grpc-fullnode v1.0.0 (D:\a\aptos-core\aptos-core\ecosystem\indexer-grpc\indexer-grpc-fullnode)`

Caused by:
  failed to load source for dependency `aptos-moving-average`

Caused by:
  Unable to update https://github.com/aptos-labs/aptos-indexer-processors.git?rev=bf4dd89677e6929ef21f898a7a4[17](https://github.com/aptos-labs/aptos-core/actions/runs/13023833521/job/36329504932#step:8:18)6514e606ebd#bf4dd896

Caused by:
  path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/aptos-indexer-processors-4a0c[23](https://github.com/aptos-labs/aptos-core/actions/runs/13023833521/job/36329504932#step:8:24)3e54c07e0d/bf4dd89/rust/integration-tests/sdk_expected_db_output_files/imported_mainnet_txns/account_transactions_processor/test_mainnet_block_metadata_transaction/account_transactions.json'; class=Filesystem (30)

Stack overflow fix:
https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows

How Has This Been Tested?

https://github.com/gregnazario/aptos-core/actions/runs/13025511981

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@gregnazario gregnazario requested a review from a team as a code owner January 29, 2025 05:17
Copy link

trunk-io bot commented Jan 29, 2025

⏱️ 1h 44m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 21m 🟩🟩🟩🟩
test-target-determinator 19m 🟩🟩🟩🟩
check-dynamic-deps 18m 🟩🟩🟩🟩🟩 (+1 more)
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-doc-tests 7m 🟩
rust-doc-tests 7m 🟩
rust-doc-tests 7m 🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 2m 🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 58s 🟩🟩🟩🟩
execution-performance / single-node-performance 44s 🟩🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩🟩 (+1 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 1m 2m -41%

settingsfeedbackdocs ⋅ learn more about trunk.io

@gregnazario gregnazario force-pushed the fix-windows-cli-builds branch from f579b7f to 372ed77 Compare January 29, 2025 05:17
@gregnazario gregnazario enabled auto-merge (squash) January 29, 2025 05:17
@gregnazario gregnazario force-pushed the fix-windows-cli-builds branch from 372ed77 to ae6ac0a Compare January 29, 2025 06:01
Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u ser

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8

Compatibility test results for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8 (PR)
1. Check liveness of validators at old version: 424ad1cab67f25b948e2090f274e2f55dba59dc9
compatibility::simple-validator-upgrade::liveness-check : committed: 11888.76 txn/s, latency: 2601.39 ms, (p50: 2500 ms, p70: 2800, p90: 3500 ms, p99: 4500 ms), latency samples: 400220
2. Upgrading first Validator to new version: 32b7639133210e01fb8a24f0e6d14e5febe1dec8
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4456.82 txn/s, latency: 6958.32 ms, (p50: 7700 ms, p70: 8300, p90: 8600 ms, p99: 8700 ms), latency samples: 93200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4221.60 txn/s, latency: 7992.96 ms, (p50: 8700 ms, p70: 8900, p90: 9800 ms, p99: 10000 ms), latency samples: 151520
3. Upgrading rest of first batch to new version: 32b7639133210e01fb8a24f0e6d14e5febe1dec8
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3818.73 txn/s, latency: 8121.07 ms, (p50: 8800 ms, p70: 9500, p90: 9900 ms, p99: 10100 ms), latency samples: 85900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3780.44 txn/s, latency: 9042.48 ms, (p50: 10000 ms, p70: 10000, p90: 10100 ms, p99: 10300 ms), latency samples: 134900
4. upgrading second batch to new version: 32b7639133210e01fb8a24f0e6d14e5febe1dec8
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7256.66 txn/s, latency: 4175.44 ms, (p50: 4300 ms, p70: 4700, p90: 5800 ms, p99: 5900 ms), latency samples: 135900
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7105.10 txn/s, latency: 4794.95 ms, (p50: 4900 ms, p70: 5600, p90: 5800 ms, p99: 6200 ms), latency samples: 241480
5. check swarm health
Compatibility test for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 32b7639133210e01fb8a24f0e6d14e5febe1dec8

two traffics test: inner traffic : committed: 14715.06 txn/s, latency: 2694.87 ms, (p50: 2400 ms, p70: 2700, p90: 3000 ms, p99: 9600 ms), latency samples: 5595020
two traffics test : committed: 99.99 txn/s, latency: 2342.78 ms, (p50: 1400 ms, p70: 1600, p90: 2700 ms, p99: 19100 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.340, avg: 1.120", "ConsensusProposalToOrdered: max: 0.295, avg: 0.292", "ConsensusOrderedToCommit: max: 0.430, avg: 0.409", "ConsensusProposalToCommit: max: 0.721, avg: 0.701"]
Max non-epoch-change gap was: 1 rounds at version 6271463 (avg 0.00) [limit 4], 1.84s no progress at version 6271463 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.67s no progress at version 2542487 (avg 0.67s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8

Compatibility test results for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8 (PR)
Upgrade the nodes to version: 32b7639133210e01fb8a24f0e6d14e5febe1dec8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1016.43 txn/s, submitted: 1019.09 txn/s, failed submission: 2.67 txn/s, expired: 2.67 txn/s, latency: 2759.91 ms, (p50: 1600 ms, p70: 2100, p90: 7300 ms, p99: 14200 ms), latency samples: 91502
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1591.52 txn/s, submitted: 1595.51 txn/s, failed submission: 3.99 txn/s, expired: 3.99 txn/s, latency: 1805.05 ms, (p50: 1600 ms, p70: 2100, p90: 2900 ms, p99: 4200 ms), latency samples: 143760
5. check swarm health
Compatibility test for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> 32b7639133210e01fb8a24f0e6d14e5febe1dec8 passed
Upgrade the remaining nodes to version: 32b7639133210e01fb8a24f0e6d14e5febe1dec8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 711.14 txn/s, submitted: 713.14 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 3958.77 ms, (p50: 1900 ms, p70: 5100, p90: 9600 ms, p99: 13600 ms), latency samples: 63960
Test Ok

@gregnazario gregnazario merged commit 85f0417 into aptos-labs:main Jan 29, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants