Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Allow long paths in windows CLI build #15840

Merged
merged 3 commits into from
Jan 29, 2025
+11 −2
Merged

[cli] Allow long paths in windows CLI build #15840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae6ac0a
[cli] Allow long paths in windows CLI build
gregnazario Jan 29, 2025
d4426ce
Merge branch 'main' into fix-windows-cli-builds
gregnazario Jan 29, 2025
32b7639
Merge branch 'main' into fix-windows-cli-builds
gregnazario Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/cli-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ jobs:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.source_git_ref_override }}
# Ensure that long paths work
- name: Ensure long paths work
run: git config --system core.longpaths true
shell: bash
- name: Build CLI
run: scripts\cli\build_cli_release.ps1
- name: Upload Binary
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/windows-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ name: "Windows CLI Build"
on:
workflow_dispatch:
pull_request:
types: [labeled, opened, synchronize, reopened, auto_merge_enabled]
schedule:
types: [ labeled, opened, synchronize, reopened, auto_merge_enabled ]
schedule:
# Run twice a day at 12PM PT and 8PM PT Monday through Friday
- cron: "0 19,3 * * 1-5"
# Run once a day at 12PM PT on Saturday and Sunday
Expand All @@ -32,6 +32,11 @@ jobs:
- name: Set up WinGet
run: Set-Variable ProgressPreference SilentlyContinue ; PowerShell -ExecutionPolicy Bypass -File scripts/windows_dev_setup.ps1

# Ensure that long paths work
- name: Ensure long paths work
run: git config --system core.longpaths true
shell: bash

# This action will cache ~/.cargo and ./target (or the equivalent on Windows in
# this case). See more here:
# https://github.com/Swatinem/rust-cache#cache-details
Expand Down
Loading