Skip to content

Commit

Permalink
Show effect of vue/html-self-closing rule re #172
Browse files Browse the repository at this point in the history
jacobtylerwalls committed Jan 3, 2025
1 parent e8f9a00 commit 3992349
Showing 13 changed files with 24 additions and 23 deletions.
Original file line number Diff line number Diff line change
@@ -17,6 +17,6 @@ defineEmits(["update"]);
<div v-if="mode === VIEW">
<ControlledListItemViewer :value="value" />
</div>
<div v-if="mode === EDIT"></div>
<div v-if="mode === EDIT" />
</div>
</template>
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ function confirmDelete(tileId: string) {
<ConfirmDialog
:pt="{ root: { style: { fontFamily: 'sans-serif' } } }"
:group="metaStringText.name"
></ConfirmDialog>
/>
<div v-if="props.metaStrings?.length">
<DataTable
v-model:expanded-rows="expandedRows"
@@ -65,7 +65,7 @@ function confirmDelete(tileId: string) {
<slot
name="name"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column
@@ -76,7 +76,7 @@ function confirmDelete(tileId: string) {
<slot
name="type"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column
@@ -87,7 +87,7 @@ function confirmDelete(tileId: string) {
<slot
name="language"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column>
@@ -124,7 +124,7 @@ function confirmDelete(tileId: string) {
<slot
name="drawer"
:row-data="slotProps.data"
></slot>
/>
</div>
</template>
</DataTable>
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ const items = ref([
<i
:class="item.icon"
aria-hidden="true"
></i>
/>
<span style="font-weight: var(--p-button-label-font-weight)">
{{ item.label }}
</span>
Original file line number Diff line number Diff line change
@@ -145,17 +145,15 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_ascribed_relation
"
>
</ControlledListItem>
/>
</template>
<template #language="{ rowData }">
<ControlledListItem
:value="
(rowData as AppellativeStatus)
.appellative_status_ascribed_name_language
"
>
</ControlledListItem>
/>
</template>
<template #drawer="{ rowData }">
<div>
@@ -165,7 +163,7 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_data_assignment_object_used
"
></ResourceInstanceRelationships>
/>
</div>
<div>
<span>{{ $gettext("Contributors:") }}</span>
@@ -174,7 +172,7 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_data_assignment_actor
"
></ResourceInstanceRelationships>
/>
</div>
</template>
</MetaStringViewer>
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ function onNamespaceNameUpdate(val: string) {
<Button
:label="$gettext('Update')"
@click="save"
></Button>
/>
</div>
</div>
</template>
Original file line number Diff line number Diff line change
@@ -162,5 +162,5 @@ function editSectionValue(tileId: string) {
</MetaStringViewer>
</SchemeReportSection>
</div>
<div v-if="mode === EDIT"></div>
<div v-if="mode === EDIT" />
</template>
Original file line number Diff line number Diff line change
@@ -19,11 +19,11 @@ const props = defineProps<{
<Button
:label="$gettext(`Add ${props.titleText}`)"
@click="$emit(OPEN_EDITOR)"
></Button>
/>
</div>
</div>
<div class="content">
<slot></slot>
<slot />
</div>
</div>
</template>
Original file line number Diff line number Diff line change
@@ -187,6 +187,6 @@ function onCreationUpdate(val: string[]) {
<Button
:label="$gettext('Update')"
@click="save"
></Button>
/>
</div>
</template>
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ const items = ref([
<i
:class="item.icon"
aria-hidden="true"
></i>
/>
</RouterLink>
</div>
</aside>
4 changes: 2 additions & 2 deletions arches_lingo/src/arches_lingo/components/tree/TreeRow.vue
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ const toggleFocus = (node: TreeNode) => {

<template>
<!-- eslint-disable vue/no-v-html -->
<span v-html="rowLabel(node.data)"></span>
<span v-html="rowLabel(node.data)" />
<!-- eslint-enable vue/no-v-html -->
<i
v-tooltip="{
@@ -76,5 +76,5 @@ const toggleFocus = (node: TreeNode) => {
:style="{ alignSelf: 'center', marginLeft: '1rem' }"
@click="toggleFocus(node)"
@keyup.enter="toggleFocus(node)"
></i>
/>
</template>
Original file line number Diff line number Diff line change
@@ -57,6 +57,6 @@ const greeting = computed(() => {
<Button
:label="$gettext('Sign out')"
@click="issueLogout"
></Button>
/>
</div>
</template>
2 changes: 1 addition & 1 deletion arches_lingo/src/arches_lingo/pages/LoginPage.vue
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import LoginLinks from "@/arches_lingo/components/login/LoginLinks.vue";
<template>
<div class="login-container">
<LoginForm />
<div class="spacer"></div>
<div class="spacer" />
<LoginLinks />
</div>
</template>
3 changes: 3 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -38,6 +38,9 @@ export default [
},
"rules": {
"semi": ["error", "always"],
"vue/html-self-closing": [
"error", { "html": { "void": "any" } }
],
},
},
];

0 comments on commit 3992349

Please sign in to comment.