You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
eslint warnings (vs. errors) don't fail the build or CI. I think it would be better to either silence messages we don't care about or elevate them to errors, otherwise they'll just accumulate.
Our eslint config pulls in some rules configured at the warning level, here:
If you elevate one of them to an error, you get a bunch of fixes generated by the pre-commit hook. (I've also tinkered with this particular option following this instruction for prettier compat.)
eslint warnings (vs. errors) don't fail the build or CI. I think it would be better to either silence messages we don't care about or elevate them to errors, otherwise they'll just accumulate.
Our eslint config pulls in some rules configured at the warning level, here:
arches-lingo/eslint.config.mjs
Line 11 in e8f9a00
If you elevate one of them to an error, you get a bunch of fixes generated by the pre-commit hook. (I've also tinkered with this particular option following this instruction for prettier compat.)
I'll PR the fixes so you can see it.
But we already have some other warnings in the build if you
npm run eslint:check
:☝️ seems like something would have been nice to address at the source
/cc @chrabyrd
The text was updated successfully, but these errors were encountered: