Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test #1123

Merged
merged 3 commits into from
Feb 27, 2025
Merged

fix test #1123

merged 3 commits into from
Feb 27, 2025

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Feb 27, 2025

Fixes a broken integration test

Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #1123 will improve performances by ×2.2

Comparing fix-embedding (21eabfa) with develop (2d4ec9a)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cache_time 1,185.5 ms 537.4 ms ×2.2

Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1123/

@plaguss plaguss merged commit d09626f into develop Feb 27, 2025
8 checks passed
@plaguss plaguss deleted the fix-embedding branch February 27, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant