Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test #1123

Merged
merged 3 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/distilabel/models/llms/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def _prepare_kwargs(
Args:
arguments: The arguments that would be passed to the LLM as **kwargs.
to update with the structured output configuration.
structured_outputs: The structured output configuration to update the arguments.
structured_output: The structured output configuration to update the arguments.

Returns:
kwargs updated with the special arguments used by `instructor`.
Expand Down
2 changes: 1 addition & 1 deletion src/distilabel/pipeline/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ def _set_runtime_parameters(self, parameters: Dict[str, Dict[str, Any]]) -> None

Args:
parameters: A dictionary with the step name as the key and a dictionary with
the parameter name as the key and the parameter value as the value.
the parameter name as the key and the parameter value as the value.
"""
step_names = set(self.dag.G)
for step_name, step_parameters in parameters.items():
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/test_embedding_dedup.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def test_embedding_deduplication() -> None:

# NOTE: Guide to choose an index: https://github.com/facebookresearch/faiss/wiki/Guidelines-to-choose-an-index
nn = FaissNearestNeighbour(
k=3,
k=5,
metric_type=faiss.METRIC_INNER_PRODUCT,
search_batch_size=50,
# string_factory="IVF300_HNSW32,Flat",
Expand All @@ -122,8 +122,8 @@ def test_embedding_deduplication() -> None:

ds = distiset["default"]["train"]
ds_dedup = ds.filter(lambda x: x["keep_row_after_embedding_filtering"])
print(len(ds_dedup))
assert len(ds_dedup) == 71

assert len(ds_dedup) == 63


if __name__ == "__main__":
Expand Down