Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer interface #135

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

romanodanilo
Copy link
Contributor

Description

  • Remove xodr and xosc reference from viewer interface
  • Remove legacy images about ConfigGUI
  • Fix some comments referring to xodr or xosc instead of input

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

Notes

Signed-off-by: romanodanilo <[email protected]>
@andreaskern74
Copy link
Collaborator

Cool. When this is merged, then I can re-compile my plugin. The current problem (I sent the screenshot via mail) is already fixed.

@hoangtungdinh hoangtungdinh self-requested a review August 23, 2024 09:19
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh merged commit 7c08f1d into develop Aug 23, 2024
4 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/fix_viewer_plugin_interface branch August 23, 2024 09:20
hoangtungdinh pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants