fix: 「配列」の章における typo などを修正 #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for js-primer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
morinokami
commented
Feb 10, 2023
| const sparseArray = [1,, 3]; | ||
| const sparseArray = [1, , 3]; |
There was a problem hiding this comment.
[1,,3] または [1, , 3] のいずれかでないとスペースの置き方としておかしいと思いました。章の後半の
js-primer/source/basic/array/README.md
Line 213 in 4170c29
などで後者の書き方がされていたため、そちらに合わせました。
morinokami
commented
Feb 10, 2023
Comment on lines
-511
to
+515
| // 引数なしは 1 を指定した場合と同じ | ||
| // 引数なしは1を指定した場合と同じ | ||
| console.log(array.flat()); // => [["A"], "B", "C"] | ||
| console.log(array.flat(1)); // => [["A"], "B", "C"] | ||
| console.log(array.flat(2)); // => ["A", "B", "C"] | ||
| // すべてをフラット化するには Infinity を渡す | ||
| // すべてをフラット化するにはInfinityを渡す |
There was a problem hiding this comment.
js-primer の文章（コメントなども含む）では数字や英単語のまわりにスペースを置く書き方はしていないと思いますが、なぜかここではスペースがありました。一貫性を保つため削除しました。
morinokami
commented
Feb 10, 2023
| @@ -537,7 +537,6 @@ console.log(array.flat()); // => ["A", "B", "C"] | |||
| `splice`メソッドを利用すると、削除した要素を自動で詰めることができます。 | |||
| `splice`メソッドは指定したインデックスから、指定した数だけ要素を取り除き、必要ならば要素を同時に追加できます。 | |||
|
|
|||
| {{book.console}} | |||
There was a problem hiding this comment.
ここは実行されることを意図したプログラムではないと思うので、削除しました。
There was a problem hiding this comment.
今気付きましたが、#1582 の issue と同内容のようです。
|
ありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
「配列」の章において何点か誤記や記述が一貫性を欠く箇所などを見つけたため、修正しました。