fix: remove clumsy prettier plugin hoisting #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
added a commit
to aspect-build/aspect-workflows-template
that referenced
this pull request
Oct 22, 2024
It didn't work correctly because prettier runs outside the sandbox and finds node_modules in the source tree. Instead the plugin loading should be explicit, and point prettier at the right config file
alexeagle
force-pushed
the
prettier-plugins
branch
from
2d4dd95
to
61ed0cb
Compare
jbedard
approved these changes
Oct 23, 2024
alexeagle
added a commit
to aspect-build/aspect-workflows-template
that referenced
this pull request
Oct 24, 2024
* chore: upstream aspect-build/rules_lint#417 * Update BUILD.bazel * Update prettier.config.cjs * Update prettier.config.cjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't work correctly because
bazel rundoes not use a sandbox, so prettier finds the config file in the source tree and then finds node_modules in the source tree. Instead the plugin loading should be explicit, and point prettier at the right config fileFixes #176