Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove clumsy prettier plugin hoisting #417

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: remove clumsy prettier plugin hoisting #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 4 additions & 30 deletions docs/format.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions example/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@ js_library(
js_library(
name = "stylelintrc",
srcs = ["stylelint.config.mjs"],
deps = [
":node_modules/stylelint-config-standard",
],
deps = [":node_modules/stylelint-config-standard"],
)

js_library(
name = "prettierrc",
srcs = ["prettier.config.cjs"],
deps = [":node_modules/prettier-plugin-sql"],
)

# NB: this alias does NOT cause Bazel's Loading phase to load the tools/BUILD file.
Expand Down
1 change: 0 additions & 1 deletion example/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ npm.npm_translate_lock(
pnpm_lock = "//:pnpm-lock.yaml",
public_hoist_packages = {
"typescript-eslint": [""],
"prettier-plugin-sql": [""],
},
)
use_repo(npm, "npm")
Expand Down
10 changes: 0 additions & 10 deletions example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,5 @@
"stylelint-config-standard": "^36.0.1",
"typescript": "4.9.5",
"typescript-eslint": "^7.10.0"
},
"//FIXME(alexeagle)": "This section shouldn't be needed since these are plugins",
"pnpm": {
"packageExtensions": {
"prettier": {
"peerDependencies": {
"prettier-plugin-sql": "*"
}
}
}
}
}
Loading
Loading